Bug 412092 - Screen orientation icons have weird tooltip positioning
Summary: Screen orientation icons have weird tooltip positioning
Alias: None
Product: KScreen
Classification: Plasma
Component: kcm (show other bugs)
Version: 5.16.90
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kscreen-bugs-null@kde.org
Depends on:
Reported: 2019-09-19 22:49 UTC by petrk
Modified: 2019-10-16 20:59 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.1

misplaced tooltips (38.44 KB, image/jpeg)
2019-09-20 22:07 UTC, petrk

Note You need to log in before you can comment on or make changes to this bug.
Description petrk 2019-09-19 22:49:48 UTC
I believe that new controls for changing screen orientation are too hard to read.

Can just a classic approach of a drop-down menu be considered instead?

Operating System: Arch Linux 
KDE Plasma Version: 5.16.90
KDE Frameworks Version: 5.62.0
Qt Version: 5.13.1
Kernel Version: 5.2.14-zen2-1-zen
OS Type: 64-bit
Processors: 4 × , 4 × Intel® Core™ i7-3720QM CPU @ 2.60GHz
Memory: 15,5 GiB
Comment 1 Nate Graham 2019-09-20 16:25:20 UTC
We had a combo box in the past, but it just showed the same thing as what we have now. The new button-based UI allows you to the same thing with a single click rather than two clicks or a click-and-hold.

Can you quantify what you don't like about the new one?
Comment 2 petrk 2019-09-20 21:56:15 UTC
It's just that it was hard for me to decipher meaning behind each icon. Thankfully there are mouseover tooltips.
These icons are tiny, also people don't use square shaped screens that often.

I'd like to suggest wider icon instead as a compromise, or a drop down menu.
Comment 3 Roman Gilg 2019-09-20 21:58:15 UTC
The issue is also with these toolbar buttons that they have this massive gap between icon and edge. The icon could fill much more of the button.
Comment 4 petrk 2019-09-20 22:07:21 UTC
Created attachment 122772 [details]
misplaced tooltips

Another issue I just noticed, tooltips appear in weird spots.
Comment 5 Nate Graham 2019-09-20 22:09:29 UTC
Thanks for the info.
Comment 6 David Edmundson 2019-10-08 10:51:25 UTC
It's due to us rotating the buttons. 

Which is already technically wrong, we're making wild assumptions about the style. On oxygen it would rotate the shadow.

We need to have 4 icons instead.
Comment 7 David Edmundson 2019-10-16 20:37:23 UTC
Git commit ae555055b2ea8e41ebd8056c2b69451b893915da by David Edmundson.
Committed on 16/10/2019 at 20:37.
Pushed by davidedmundson into branch 'Plasma/5.17'.

[kcm] Don't transform button to show rotated icon

Rotating a button leads to tooltips being broken, it will lead to
shadows being broken on a theme that uses shadows and is generally not

This patch sets the contentItem explicitly and rotates that

Reviewers: #plasma, ngraham, romangg

Reviewed By: #plasma, ngraham, romangg

Subscribers: romangg, mart, ngraham, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24488

M  +8    -10   kcm/package/contents/ui/RotationButton.qml