Bug 412061 - Rotating selection with Transform Tool makes the selection edge rough
Summary: Rotating selection with Transform Tool makes the selection edge rough
Status: RESOLVED INTENTIONAL
Alias: None
Product: krita
Classification: Applications
Component: Tools/Transform (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-19 13:05 UTC by acc4commissions
Modified: 2019-09-21 14:17 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
attachment picture (35.89 KB, image/png)
2019-09-19 13:05 UTC, acc4commissions
Details
attachment picture 2 (19.50 KB, image/png)
2019-09-19 13:29 UTC, acc4commissions
Details

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2019-09-19 13:05:54 UTC
Created attachment 122723 [details]
attachment picture

SUMMARY
Both 4.2.6, latest nightlies.

STEPS TO REPRODUCE
1. Select any area with any(Rectangular, Elliptical, Poligonal, Outline, etc) selection tool and paint on it(So that it becomes possible to transform).
2. Rotate, apply.

OBSERVED RESULT
Rough edges appear.

EXPECTED RESULT
Clean edges.

SOFTWARE/OS VERSIONS
Windows: Win7
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Scott Petrovic 2019-09-19 13:11:04 UTC
When did this start? Can you give a better example than a rectangle shape? There is always going to be some jaggies when you rotate something like that.
This is just how computers work (unless you are talking about something I don't understand). People usually just get around this by either 

1. Increase the DPI so it minimizes the jaggies
2. Work with vector files so the edges are calculated mathematically

If I am not understanding, please explain it differently
Comment 2 acc4commissions 2019-09-19 13:29:19 UTC
Created attachment 122725 [details]
attachment picture 2

Left : 4.1.5
Right : git b6d75fa

Not this amount. Something definitely has changed along the updates. But I'm not sure exactly when. I'm not the dev. :/
Comment 3 acc4commissions 2019-09-19 13:31:11 UTC
Changing dpi doesn't make a difference.
Comment 4 Bug Janitor Service 2019-09-20 04:33:09 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 5 wolthera 2019-09-20 10:23:44 UTC
Which transformation filter(nearest neighbour, bicubic) are you using?
Comment 6 acc4commissions 2019-09-20 10:41:38 UTC
(In reply to wolthera from comment #5)
> Which transformation filter(nearest neighbour, bicubic) are you using?

Ok. Turns out it only happens with the Lanczos3 filter.
So is it supposed to be in this way? (It seems to be the cleanest filter.)
Comment 7 Ahab Greybeard 2019-09-20 11:39:47 UTC
The Lanczos3 filter is known to produce 'ringing' on sharp edges despite being 'generally good'.

I'm sure this was explained in the manual in a list of filter/interpolation options for the general case but I can now only find one reference to it in Scene Linear painting:

"Speaking of filters, when using the transform tool, you should also avoid using lanczos3, it’ll give a weird black halo to sharp contrasts in scene-linear."
Comment 8 Bug Janitor Service 2019-09-21 04:33:09 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 9 wolthera 2019-09-21 14:17:57 UTC
Yes, it is supossed to be this way with the lanczos filter, the ring artifacts are a side-effect of how the lanczos filter applies a little bit of edge sharpning to get it's sharp results.