Bug 411973 - Add a second line to the tooltip
Summary: Add a second line to the tooltip
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Power and Battery widget (other bugs)
Version First Reported In: master
Platform: unspecified Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-16 14:03 UTC by Lucia Mrenica
Modified: 2020-07-09 19:21 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.19.0
Sentry Crash Report:


Attachments
tooltip of battery applet on neon unstable (30.03 KB, image/png)
2020-07-09 19:05 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lucia Mrenica 2019-09-16 14:03:51 UTC
Showing something usefull like remaining time on battery or time to charge.
This would also make the tooltip the same size (height) as its "neighbours".
Comment 1 Nate Graham 2019-09-18 17:43:11 UTC
Not a bad idea at all.
Comment 2 Nate Graham 2019-09-18 21:14:31 UTC
Here's the code, if you'd like to give it a try: https://cgit.kde.org/plasma-workspace.git/tree/applets/batterymonitor/package/contents/ui/batterymonitor.qml#n83
Comment 3 Lucia Mrenica 2019-09-19 07:55:24 UTC
(In reply to Nate Graham from comment #2)
> Here's the code, if you'd like to give it a try:
> https://cgit.kde.org/plasma-workspace.git/tree/applets/batterymonitor/
> package/contents/ui/batterymonitor.qml#n83

Here it is: https://phabricator.kde.org/D24070. Could it still make into Plasma 5.17?
Comment 4 Nate Graham 2020-03-13 19:08:33 UTC
Git commit db2518b063e493da5bf5f5a48c931ff51bd22924 by Nate Graham, on behalf of Matej Mrenica.
Committed on 13/03/2020 at 19:08.
Pushed by ngraham into branch 'master'.

[Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

Summary:
Currently the applet uses the main line in tooltip to display all info. Instead it should show always the same first line like other widgets and use the second line to show info.
FIXED-IN: 5.19.0

Test Plan:
The point of this patch is to make the tooltip more like the style used in the Audio Volume applet:
{F7862465}

Other "after" images:

{F7862461}

{F7862463}

{F7862464}

{F7871067}

Reviewers: #vdg, #plasma, broulik, ndavis, mthw

Reviewed By: #vdg, #plasma, broulik, ndavis, mthw

Subscribers: GB_2, ndavis, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24070

M  +29   -21   applets/batterymonitor/package/contents/ui/batterymonitor.qml

https://commits.kde.org/plasma-workspace/db2518b063e493da5bf5f5a48c931ff51bd22924
Comment 5 Patrick Silva 2020-07-09 19:05:00 UTC
Created attachment 130003 [details]
tooltip of battery applet on neon unstable

Humm, I don't see a second line on neon unstable and openSuse krypton.
Can anyone confirm?
Comment 6 Nate Graham 2020-07-09 19:21:02 UTC
The second line has information about how long the battery will take to full charge or discharge, and will not be visible if the power daemon isn't currently providing that information for whatever reason.