Bug 411847 - captive portal detection notification duplicated
Summary: captive portal detection notification duplicated
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Networking in general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Jan Grulich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-12 09:10 UTC by Harald Sitter
Modified: 2024-12-23 18:23 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-nm/1ffef126b8f0b8ca58ee88cc2e3d235a51dbf288
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2019-09-12 09:10:34 UTC 
the captive portal notification is not managed and simply stays there forever. this results in a number of awkward ways the 

STEPS TO REPRODUCE
1. be behind portal
2. have nm properly set up to detect limited connectivity
3. get notification upon connecting

OBSERVED RESULT
when disconnecting from the wifi connection that caused the portal and then reconnecting there are two notifications. re-connect again and there's three... etc. etc.

EXPECTED RESULT
notification goes away
Comment 1 Jan Grulich 2019-12-17 09:47:48 UTC 
Git commit 1ffef126b8f0b8ca58ee88cc2e3d235a51dbf288 by Jan Grulich.
Committed on 17/12/2019 at 09:47.
Pushed by grulich into branch 'master'.

Captive portal notification improvements

Summary:
Do not duplicate captive portal notifications and close them when we are no longer
behind captive portal.
Related: bug 411846

Reviewers: ngraham, broulik, #plasma

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26042

M  +34   -11   kded/portalmonitor.cpp
M  +4    -0    kded/portalmonitor.h

https://commits.kde.org/plasma-nm/1ffef126b8f0b8ca58ee88cc2e3d235a51dbf288
Comment 2 Ben Cooksley 2024-12-23 18:23:41 UTC 
Bulk transfer as requested in T17796