Bug 411841 - Partition Manager doesn't actually edit fstab
Summary: Partition Manager doesn't actually edit fstab
Status: RESOLVED DUPLICATE of bug 417205
Alias: None
Product: partitionmanager
Classification: Applications
Component: general (show other bugs)
Version: 4.0.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Andrius Štikonas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-12 06:02 UTC by nosewings
Modified: 2020-09-15 01:19 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.2.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nosewings 2019-09-12 06:02:03 UTC
SUMMARY
When attempting to add a mount point via Partition Manager, no change is made to /etc/fstab.

STEPS TO REPRODUCE
1. Add a mount point to a partition that doesn't have one (NTFS, if that matters).
2. Click "Save Changes".

OBSERVED RESULT
/etc/fstab is unchanged. Partition Manager remembers the mount point until it is closed.

EXPECTED RESULT
/etc/fstab is changed to include the new point point.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.61.0
Qt Version: 5.13.1
Kernel Version: 5.2.13-arch1-1-ARCH
Comment 1 Lance Haverkamp 2019-09-13 05:58:03 UTC
NTFS does not seem to matter, I have the same problem with the current EXT4 on KDE-Neon 5.16 (?)

fstab is completely untouched, even though the root password was requested & entered at program launch.  No error message, it just fails to enter the requested changes.
Comment 2 Andrius Štikonas 2020-02-05 20:24:34 UTC
*** Bug 417205 has been marked as a duplicate of this bug. ***
Comment 3 Ben Bullard 2020-05-23 03:43:35 UTC
I'm seeing this in OpenMandriva Lx 4.1 with KDE Partition Manager 4.0:

Plasma 5.17.5
Frameworks 5.66.0
Qt 5.14.1
Kernel 5.5.12-desktop-1omv4001

Exactly as nosewings@gmail.com describes nothing gets written to /etc/fstab. I know this used to work at one time. I have tested this with ext4 and ntfs.

Also the issue persists in our developer version Cooker with KDE Partition Manager 4.1 and:

Plasma 5.18.90
Frameworks 5.70.0
Qt 5.15.0  (This is RC2 I believe)
Kernel 5.6.14-desktop-1omv4002
Comment 4 Ben Bullard 2020-05-23 03:56:48 UTC
Uh, oh. I might be brain dead. Just realized this report is specific to Arch Linux packages. 

Apologies for that.
Comment 5 Andrius Štikonas 2020-05-23 10:33:50 UTC
(In reply to Ben Bullard from comment #4)
> Uh, oh. I might be brain dead. Just realized this report is specific to Arch
> Linux packages. 
> 
> Apologies for that.

No, it's definitely fine to report other distros. Don't pay too much attention to that distro combobox, it's just distro that initial reported used but clearly this bug is not distro specific.
Comment 6 Timon Zielonka 2020-06-02 08:33:19 UTC
Same on Kubuntu 20.04 with

KDE-Partitionsverwaltung Version 4.1.0
KDE Frameworks 5.68.0
Qt 5.12.8 (kompiliert gegen 5.12.8)
Kernel Version: 5.4.0-33-generic
Comment 7 Timon Zielonka 2020-06-02 08:47:24 UTC
When this bug is solved this could be added to https://github.com/KDE/kpmcore/tree/master/test to prevent this happening again in the future. Or is this not a good idea to create a test case for this?
Comment 8 Andrius Štikonas 2020-06-02 09:40:30 UTC
(In reply to Timon Zielonka from comment #7)
> When this bug is solved this could be added to
> https://github.com/KDE/kpmcore/tree/master/test to prevent this happening
> again in the future. Or is this not a good idea to create a test case for
> this?

Yes, I think it would be a good idea. I just need to find some spare time. Anyway, I'll try to fix this bug before the next release.
Comment 9 Andrius Štikonas 2020-09-10 18:11:50 UTC
I've debugged the issue. It was a bug in writeMountpoints function (writing to QByteArray).

I have a fix now but need to do some more code cleanups (to reduce duplication) and testing.
Comment 10 Andrius Štikonas 2020-09-15 00:13:25 UTC
Fix will be in 4.2.0

*** This bug has been marked as a duplicate of bug 417205 ***
Comment 11 Ben Bullard 2020-09-15 01:06:31 UTC
(In reply to Andrius Štikonas from comment #10)
> Fix will be in 4.2.0
> 
> *** This bug has been marked as a duplicate of bug 417205 ***

Thanks, and thanks for your time and effort on this project in general. We at OpenMandriva appreciate it.
Comment 12 Andrius Štikonas 2020-09-15 01:19:47 UTC
(In reply to Ben Bullard from comment #11)
> (In reply to Andrius Štikonas from comment #10)
> > Fix will be in 4.2.0
> > 
> > *** This bug has been marked as a duplicate of bug 417205 ***
> 
> Thanks, and thanks for your time and effort on this project in general. We
> at OpenMandriva appreciate it.

And thanks for leaving feedback. It's nice to hear positive feedback too.

I'll probably aim to release a new version reasonably soon, maybe in a couple of weeks. There is another crash that got fixed and had LOTS of duplicate bug reports (although, hard to reproduce reliably).