Bug 411816 - Not possible to pick color from reference image from color picker inside tools
Summary: Not possible to pick color from reference image from color picker inside tools
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (show other bugs)
Version: 4.2.6
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-11 11:19 UTC by Marcos
Modified: 2019-09-23 10:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos 2019-09-11 11:19:39 UTC
SUMMARY
Not possible to pick color from reference image from color picker inside tools


STEPS TO REPRODUCE
1. Open a Krita document
2. Add a reference image
3. Open color selector in "brushes and stuff" toolbar
4. Pick a color from the previously added reference image


OBSERVED RESULT
Krita picks color below reference image. If outside canvas doesn't pick any.


EXPECTED RESULT
Krita picks desired color


ADDITIONAL INFORMATION
Can also be reproduced from the color picker inside svg text tool, so I'm assuming is an oversight in built-in color pickers.
Comment 1 Halla Rempt 2019-09-11 11:21:22 UTC
Thanks, I can confirm the bug.
Comment 2 Halla Rempt 2019-09-12 08:51:17 UTC
Weird, the commit message didn't close the bug:

commit c67c1cf2b8c9498e2310e64e14d2ee8b02562922 (HEAD -> master, origin/master, origin/HEAD)
Author: Mathias Wein <lynx.mw@gmail.com>
Date:   Wed Sep 11 20:09:41 2019 +0200
Include reference images in screen color picker
KisScreenColorPicker works directly on the krita canvas when
possible for full color gamut, but in contrast to the other
color picking tools was not taking reference images into account.
Also check against visibleRegion() instead of rect() to choose
the correct document subwindow when they overlap.
BUG:411816
Comment 3 Halla Rempt 2019-09-23 10:03:35 UTC
Git commit 42ee07653d84263c349e32369fa1940c33455cd1 by Boudewijn Rempt, on behalf of Mathias Wein.
Committed on 23/09/2019 at 09:58.
Pushed by rempt into branch 'krita/4.2'.

Include reference images in screen color picker

KisScreenColorPicker works directly on the krita canvas when
possible for full color gamut, but in contrast to the other
color picking tools was not taking reference images into account.

Also check against visibleRegion() instead of rect() to choose
the correct document subwindow when they overlap.

M  +16   -3    libs/ui/widgets/KisScreenColorPicker.cpp

https://invent.kde.org/kde/krita/commit/42ee07653d84263c349e32369fa1940c33455cd1