Bug 411622 - Add a new option to change visibility of thumbnail frame
Summary: Add a new option to change visibility of thumbnail frame
Status: REPORTED
Alias: None
Product: digikam
Classification: Applications
Component: Thumbs-IconView (show other bugs)
Version: 6.2.0
Platform: macOS (DMG) macOS
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-05 18:49 UTC by tsader
Modified: 2023-10-22 15:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
quick hack to disable iconview frames (206.61 KB, image/png)
2019-09-06 05:49 UTC, caulier.gilles
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tsader 2019-09-05 18:49:50 UTC
SUMMARY

I would like to request to be able to change the thumbnail frame and shadow

thanks


macOS: 10.14.4
Comment 1 caulier.gilles 2019-09-05 18:51:58 UTC
To be more precise, following the original post in user mailing list, this file is to be able to enable or disable the frame visibility around thumbnails with a new option in Setup dialog.
Comment 2 caulier.gilles 2019-09-06 04:55:06 UTC
Code used to draw frames around thumbnail is here:

https://github.com/KDE/digikam/blob/master/core/libs/widgets/mainview/thumbbardock.cpp#L238

Warning, there is another function used also to draw frames around thumbnail when items are grouped:

https://github.com/KDE/digikam/blob/master/core/libs/widgets/mainview/thumbbardock.cpp#L306

Gilles Caulier
Comment 3 caulier.gilles 2019-09-06 05:49:09 UTC
Created attachment 122509 [details]
quick hack to disable iconview frames

This is a quick hack to see the effect of disabling frames around thumbnail. I just comment a portion of code in the first function listed in comment #2.

First icon is for grouped items, other one are single item. I think the rendering from non grouped items is the expected result. For grouped items, it need more adjustments, as grouped feature need to be more visible in icon view. Typically, if this kind of new option to change frame visibility is add in the future, this will only affect non grouped items.

Gilles Caulier
Comment 4 caulier.gilles 2020-12-18 12:10:47 UTC
https://bugs.kde.org/show_bug.cgi?id=426938

--- Comment #4 from caulier.gilles@gmail.com ---
Hi,

digiKam 7.2.0-beta2 pre-release PKG installer now support BigSur and is
compiled with last stable Qt 5.15.2.

https://files.kde.org/digikam/

Problem still reproducible with this version.

Thanks and happy Christmas in advance

Best Regards

Gilles Caulier
Comment 5 caulier.gilles 2023-05-18 06:22:59 UTC
Maik,

I would to know your viewpoint about this file. Typically, we can add a new option, enable by default, or do not change code and close this entry as well.

Best

Gilles
Comment 6 caulier.gilles 2023-10-22 15:00:49 UTC
Maik,

Do you read my last comment ?

If you are agree to add this option, i will do it next week.

Gilles
Comment 7 Maik Qualmann 2023-10-22 15:29:48 UTC
Yes, of course we can make it configurable. I looked at various image management programs in Google Image Search. Most don't seem to draw a frame, not even a black line. Some make the thumbnails appear highlighted.

Maik