krusader is great to use via keyboard. Having to use the mouse so little is one of its main draw for me. One place where a keyboard shortcut is missing is the (de-)selection dialog. I often need to select folders, too, and for that I have to enable the "apply selection to folders" checkbox — which does not have a keyboard shortcut at the moment (my language is English). Therefore I have to use the mouse or a complicated & long sequence keys: "Alt-e" (jump to "case-sensitive"), "space" (for toggling "case-sensitive" off again), "tab" (for going to "apply selection to folders") and finally "space" (for checking "apply selection to folders"). It would be so much easier with a shortcut, e.g. Alt-d, which doesn't seem to be used in the English version of the dialog yet. Thanks! This is krusader git revision 489c122a448429724b92a8616c195c86de6e5361.
Hi, Moritz. It's strange, I can use Alt+S in that dialog. I'll attach a screenshot.
Created attachment 122430 [details] The dialog to select files (having the Alt key pressed in order to show the shortcuts)
Moritz, can you attach a screenshot (having the Alt key pressed in order to show the shortcuts)?
Thanks for the quick reaction! Sure, I'll attach a screenshot in a second. That your installation has a keyboard shortcut is most likely due to the (infamous) work of KDE's automatic shortcut injection[1] which I've turned off in order to have the shortcuts I want in the applications I write, not the ones KDE thinks I want. If you want to try this yourself, edit your ~/.config/kdeglobalsrc, add the following & restart KDE: [Development] AutoCheckAccelerators=false As you can see in the source code[2], there's no intentional accelerator in the string. [1] https://github.com/GoldenCheetah/GoldenCheetah/wiki/Working-around-KDE-shortcut-injection [2] https://github.com/KDE/krusader/blob/master/krusader/Panel/PanelView/krview.cpp#L1088 and all other occurrences in that file; see also "grep -r 'to folders'"
Created attachment 122432 [details] krusader without KDE's automatic accelerator assignment
I edited the ~/.config/kdeglobals file, added the following: [Development] AutoCheckAccelerators=false executed Krusader, and Alt+S didn't work when selecting or deselecting files. > Krusader is great to use via keyboard Yes, that's one of the biggest advantages of Krusader. Also, when people see you working a lot that way... think you work very fast :-)
> This is krusader git revision 489c122a448429724b92a8616c195c86de6e5361. Moritz, an you test the change proposed in https://phabricator.kde.org/D23606 ? In order to apply the changes you just would need to execute something similar to: cd FOLDER_WHERE_KRUSADER_CODE_IS patch -p1 < PATH_TO_THE_DIFF_FILE and rebuild Krusader.
Sure! I've built git revision ad6ceca7384e57d1dcae53db721136d70242028e combined with the patch from D23606, and Alt+S is now nicely shown as a keyboard accelerator for the checkbox, and it works as expected. This is exactly what I was hoping for. Thanks again so much for your quick reaction, Toni! I highly appreciate it.
> Sure! I've built git revision ad6ceca7384e57d1dcae53db721136d70242028e combined with the patch from D23606, and Alt+S is now nicely shown as a keyboard accelerator for the checkbox, and it works as expected. This is exactly what I was hoping for. > Thanks again so much for your quick reaction, Toni! I highly appreciate it. OK! Moritz, as you are able, would you be so kind to test those proposals Replace Q_WS_WIN with Q_OS_WIN in all the source code https://phabricator.kde.org/D22957 Avoid that Krusader crashes when trying to view any archive using the ark part https://phabricator.kde.org/D23243 ?
Of course. I've taken git revision ad6ceca7384e57d1dcae53db721136d70242028e, applied D22957, D23243 and D23606 and built the whole thing. Patches apply fine (one with two lines of offset but no fuzz). Compilation goes fine. The resulting binary works fine, though I haven't done extensive testing — just a couple of exercises involving navigation/file creation/copying files & directories/accessing other hosts via ssh/accessing tar archives. It doesn't crash when I trying to access the test files created from the instructions in D23243. The new shortcut for "apply selection to folders" works, too. TLDR: LGTM!
Thank you for your tests, Moritz!
Git commit 07848cc8ebc89876189c10bbd4e6f3e3981370db by Toni Asensi Esteve. Committed on 15/09/2019 at 15:56. Pushed by asensi into branch 'master'. Provide keyboard shortcuts in (de-)selection and (de-)filter dialogs Provide keyboard shortcuts for "Apply selection to folders" in (de-)selection dialog, and for "Apply filter to folders" in filter dialog. Other related minor changes. FIXED: [ 411446 ] Provide keyboard shortcut for "apply selection to folders" in (de-)selection dialog Differential Revision: https://phabricator.kde.org/D23606 M +15 -9 krusader/Panel/PanelView/krview.cpp https://commits.kde.org/krusader/07848cc8ebc89876189c10bbd4e6f3e3981370db