Bug 411396 - Show reviews in all languages, only use the locale to filter
Summary: Show reviews in all languages, only use the locale to filter
Status: CONFIRMED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
: 316748 415495 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-08-28 19:37 UTC by Karl Ove Hufthammer
Modified: 2023-02-05 13:23 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Ove Hufthammer 2019-08-28 19:37:47 UTC
SUMMARY
Discover doesn’t show user reviews. No matter which application I select, the review section shows ‘Be the first to write a review!’.

STEPS TO REPRODUCE
1. Open Discover.
2. Wait until ‘Fetching updates...’ is finished.
2. Select an application which has ratings.
3. Scroll down (to below the application description).

OBSERVED RESULT
The text ‘Be the first to write a review!’ is shown. And the log on the console says:
    <Unknown File>:7: TypeError: Type error
    QFSFileEngine::open: No file name specified
    file:///usr/lib64/qt5/qml/org/kde/kirigami.2/ItemViewHeader.qml:65:9: Unable to assign QQuickPopupItem to Page_QMLTYPE_63

EXPECTED RESULT
A list of reviews.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20190824
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.13.0
Kernel Version: 5.2.9-1-default
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-2500 CPU @ 3.30GHz
Memory: 15,6 GiB


ADDITIONAL INFORMATION
I observe this with the latest Git version. However, it only seem to happen with my default language settings (Norwegian Nynorsk locale). If I run Discover with LC_ALL=C, the reviews *are* shown.
Comment 1 Nate Graham 2019-09-03 17:39:14 UTC

*** This bug has been marked as a duplicate of bug 411034 ***
Comment 2 Karl Ove Hufthammer 2019-09-03 20:28:03 UTC
Reopening, as per comments in #411034. I observe this bug on the latest git master version of Discover.
Comment 3 Aleix Pol 2019-09-06 00:53:58 UTC
Are you sure there's reviews in Norwegian?
Comment 4 Øystein Steffensen-Alværvik 2019-09-07 13:08:38 UTC
I just added a review to KRename, and my locale is Norwegian Nynorsk, so it should be visible for Hufthammer (if the reviews are not linked to specific distros?).
Comment 5 Karl Ove Hufthammer 2019-09-15 12:46:43 UTC
(In reply to Øystein Steffensen-Alværvik from comment #4)
> I just added a review to KRename, and my locale is Norwegian Nynorsk, so it
> should be visible for Hufthammer (if the reviews are not linked to specific
> distros?).

I can confirm that KRename now displays this review. So it looks like Discover only shows reviews for the user’s main language. This either a bug in the ODRS service or in Discover (or both):

According to https://odrs.gnome.org/, it seems like user’s language/locale should only be used to *sort* the reviews: ‘By specifying the users current locale we can sort the potential application reviews according to a heuristic that we're still working on. Generally we want to prefer useful reviews in the users locale […]’. But reviews written in other languages are not shown *at all*, not just sorted at the bottom – so a bug in the ODRS service? (And I guess many reviews marked as being in a non-English locale are actually written in English, making this even more problematic.)

On the other hand, the KDE language/locale settings allow a *prioritised* list of languages (for example, my list is set to ‘Norwegian Nynorsk; Norwegian Bokmål; Danish; British English; American English’). So if the ODRS only returns reviews in the submitted locale, Discover should ask for reviews in all of the user’s languages and show them sorted by the preferred language. And perhaps reviews written in English should *always* be fetched? (Just like the UI in KDE applications are shown in English if the application hasn’t been translated into *any* of the user’s preferred languages.)
Comment 6 Øystein Steffensen-Alværvik 2019-09-15 12:55:26 UTC
For the ~2 years I've used KDE Plasma, I have never been able to view app reviews in Discover in other locales. I always thought that this was intended behaviour.
Comment 7 Aleix Pol 2019-10-09 16:16:34 UTC
It would need modifying odrs-web.
Comment 8 Aleix Pol 2020-01-20 16:36:48 UTC
*** Bug 415495 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2023-01-12 17:42:42 UTC
*** Bug 316748 has been marked as a duplicate of this bug. ***