Bug 411350 - Keyboard shortcut Shift+Enter does not remove entry in Krunner history
Summary: Keyboard shortcut Shift+Enter does not remove entry in Krunner history
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (other bugs)
Version First Reported In: 5.16.4
Platform: Kubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-27 13:18 UTC by Thiago Sueto
Modified: 2019-08-28 06:43 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-workspace/6f0d0a22366b9bd007c8d8f1d71f5bddc3e9a98b
Version Fixed In: 5.16.5
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Sueto 2019-08-27 13:18:51 UTC 
Pressing Shift+Enter, the proper keyboard shortcut in Krunner for removing an entry from its history, does not work as intended. Instead, it ignores the Shift and selects the entry.

SOFTWARE/OS VERSIONS
Operating System: Kubuntu 19.04 (with backports)
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.12.2
Kernel Version: 5.0.0-25-generic
Comment 1 Kai Uwe Broulik 2019-08-27 14:14:18 UTC 
It probably always shows Shift+Enter for the first action button. But agreed, it should probably trigger it there as well. The history model is separate from the results list, so that is why it doesn't "just work"
Comment 2 Kai Uwe Broulik 2019-08-28 06:43:11 UTC 
Git commit 6f0d0a22366b9bd007c8d8f1d71f5bddc3e9a98b by Kai Uwe Broulik.
Committed on 28/08/2019 at 06:42.
Pushed by broulik into branch 'Plasma/5.16'.

Replicate Shift+Enter for action invocation for history as well

This was missing from the ResultsList, just copied it over.
FIXED-IN: 5.16.5

Differential Revision: https://phabricator.kde.org/D23494

M  +10   -3    lookandfeel/contents/runcommand/RunCommand.qml

https://commits.kde.org/plasma-workspace/6f0d0a22366b9bd007c8d8f1d71f5bddc3e9a98b