SUMMARY STEPS TO REPRODUCE 1. use kmail normally, i.e. send some mails OBSERVED RESULT you will find a folder named "file:" in your home which contains the full path to your local mail folders, for example "file:/users/lemmy/.local/share with "local-mail" and "local-mail.directory" in it. EXPECTED RESULT I would expect the maildir ressource to actually understand and handle a "file://" ressource properly SOFTWARE/OS VERSIONS Operating System: openSUSE Leap 15.0 KDE Plasma Version: 5.16.4 KDE Frameworks Version: 5.61.0 Qt Version: 5.13.0 Kernel Version: 4.12.14-lp150.12.70-default OS Type: 64-bit Processors: 8 × Intel® Core™ i7-4771 CPU @ 3.50GHz Memory: 31,4 GiB ADDITIONAL INFORMATION - the "local notes" ressource does it too, so maybe it's a bug in a kio_ instead of the akonadi parts?
Git commit 93ecfacfb9f21ee027dbcfc7d5d47ddbbb253ba1 by Igor Poboiko. Committed on 01/03/2020 at 18:44. Pushed by poboiko into branch 'master'. [resources/maildir] Don't save "file:" schema to the config Summary: `ConfigWidget` uses `KConfig` underneath, and utilizes `KUrlRequester` custom widget. The `USER` property of this widget (which is used by `KConfig`) is of type `QUrl`, and thus when dialog is accepted, the `path` config property gets overriden with `QUrl::toString()` value, which prepends `file:` schema (this is basically because `KCoreConfigSkeleton::ItemPath` is inherited from `ItemString`, and when someone calls `ItemString::setProperty`, it gets casted as `QVariant::toString`). Inside the `ConfigWidget::save` the code calls `setPath` method on `url.toLocalFile`, which drops the scheme. Because of that, the `pathItem` and `path` property of `mSettings` have different values, first has schema and the second hasn't. Eventually, the value stored by `pathItem` wins, and `mSettings->path()` returns URL with schema. However, `Maildir` doesn't expect it and misinterprets it as the relative path to current WORKDIR (which is home directory), thus creating `/home/user/file:/home/user/...` file structure. The proposed solution is to simply call `mSettings->save()`, which overrides `pathItem` value and drops schema from it. It also fixes the `AkoNotes` resource, which uses the same `ConfigWidget`. Funny enough, `Contacts` resource, which is somewhat similar, is not affected as it has the same `Settings->save()` call. Alternative approaches include: 1) Teach `Maildir` to drop the schema (if it's there). 2) Teach `KCoreConfigSkeleton::ItemPath` to work with `QUrl` and don't append schema (it makes sense, because `ItemPath` corresponds to local file. Although it's not documented that it shouldn't have schema, it seems from the tests that it was the original intent). This could save the headache of having such issue in the future, but it could mess up with other programs in funny ways (as currently `file:` sometimes gets prepended, and some code might implicitly rely on it) Additional note: There are `ui.kcfg_Path->url().isLocalFile()` checks around, which doesn't make sense to me, as `KUrlRequester` is used for local files and it seems like it always returns `QUrl` pointing to local file (i.e. have the `file:` schema). Related: bug 408354, bug 413588 Test Plan: 1) Open `akonadiconsole -> Local Folders` properties, change the folder, save 2) `cat ~/.config/akonadi_maildir_resource_0rc`. `file:` schema gets prepended 2.1) `akonadictl restart`. `file:` folder gets created inside homedir 3) Apply patch, repeat (1)-(2.1). `file:` schema is dropped. Reviewers: dvratil, mlaurent Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27722 M +1 -0 resources/maildir/configwidget.cpp https://commits.kde.org/kdepim-runtime/93ecfacfb9f21ee027dbcfc7d5d47ddbbb253ba1