Created attachment 122310 [details] Image of the described bug. SUMMARY The temperature that is seen in the SMART status dialogue on storage devices is too accurate and almost always displays it with 6 zeros, e.g. 22.000000*C. This should be changed to a more reasonable accuracy. STEPS TO REPRODUCE 1. Right Click on a device > Smart Status 2. Look at 'Temperature' OBSERVED RESULT Shown 6 decimal places of temperature - see attachment. EXPECTED RESULT Shown to one or two decimal places - I'm not sure accurate most temperature meters are on drives are, but both of mine are only accurate to the nearest degree. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
Git commit 78f29ae8b5323c6ba6ea9198261fa9aa0c9f6dd9 by Shubham Jangra. Committed on 01/09/2019 at 17:41. Pushed by shubham into branch 'master'. Reduce temperature's precision from six decimal places to two Summary: BUG: 411226 Test Plan: I couldn't test it since my device does not support SMART Reviewers: stikonas Reviewed By: stikonas Subscribers: #kde_partition_manager Tags: #kde_partition_manager Differential Revision: https://phabricator.kde.org/D23572 M +1 -1 src/core/smartstatus.cpp https://invent.kde.org/kde/kpmcore/commit/78f29ae8b5323c6ba6ea9198261fa9aa0c9f6dd9
Tested this and it's working fine. Slight correction: this is significant figures not decimal places (https://doc.qt.io/qt-5/qstring.html#argument-formats)
(In reply to Mathew from comment #2) > Tested this and it's working fine. > Slight correction: this is significant figures not decimal places > (https://doc.qt.io/qt-5/qstring.html#argument-formats) Shall we use 'f', 0 ? 'g' has disadvantage that it switches to scientific notation...
I think so. Another reason why we should is that 100F≈38C, and at that point, two significant figures will be rounded the Fahrenheit value.
Git commit 4b0261230de9a0864cb457a59d6c83902c675ac6 by Andrius Štikonas. Committed on 07/09/2019 at 10:51. Pushed by stikonas into branch 'master'. Make S.M.A.R.T. disk temperature label show only integers. M +1 -1 src/core/smartstatus.cpp https://invent.kde.org/kde/kpmcore/commit/4b0261230de9a0864cb457a59d6c83902c675ac6
Git commit a264a282372b0ed44122bcfcff75702512d2c57f by Andrius Štikonas, on behalf of Shubham Jangra. Committed on 05/10/2019 at 11:07. Pushed by stikonas into branch '4.0'. Reduce temperature's precision from six decimal places to two Summary: BUG: 411226 Test Plan: I couldn't test it since my device does not support SMART Reviewers: stikonas Reviewed By: stikonas Subscribers: #kde_partition_manager Tags: #kde_partition_manager Differential Revision: https://phabricator.kde.org/D23572 M +1 -1 src/core/smartstatus.cpp https://invent.kde.org/kde/kpmcore/commit/a264a282372b0ed44122bcfcff75702512d2c57f
Git commit df235a77517709d211d029234cf6c8893b4aa131 by Andrius Štikonas. Committed on 05/10/2019 at 11:07. Pushed by stikonas into branch '4.0'. Make S.M.A.R.T. disk temperature label show only integers. M +1 -1 src/core/smartstatus.cpp https://invent.kde.org/kde/kpmcore/commit/df235a77517709d211d029234cf6c8893b4aa131