Bug 411185 - Solar system viewer has a Y2K-ish bug
Summary: Solar system viewer has a Y2K-ish bug
Status: RESOLVED FIXED
Alias: None
Product: kstars
Classification: Applications
Component: general (show other bugs)
Version: git
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Jasem Mutlaq
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-22 18:00 UTC by James Lancaster
Modified: 2019-09-15 06:50 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Lancaster 2019-08-22 18:00:14 UTC
SUMMARY
The solar system viewer only uses 2 digits, which makes for going back to other years to compare things, a bit tricky. Though it can be done with large step sizes, the widget should allow and display at least 4 digit years. 

Only change that needs to be made is to kstars/kstars/tools/planetviewer.ui Which I'm trying to submit through Phabricator (For practice, though it's a really simple one, since everything already works, it's just display)

Change is this: 


diff --git a/kstars/tools/planetviewer.ui b/kstars/tools/planetviewer.ui
index e5aedeac8..b977a7997 100644
--- a/kstars/tools/planetviewer.ui
+++ b/kstars/tools/planetviewer.ui
@@ -79,7 +79,11 @@
       </spacer>
      </item>
      <item>
-      <widget class="QDateEdit" name="DateBox" />
+      <widget class="QDateEdit" name="DateBox">
+       <property name="displayFormat">
+        <string>M/d/yyyy</string>
+       </property>
+      </widget>
      </item>
      <item>
       <widget class="QPushButton" name="TodayButton" >
Comment 1 James Lancaster 2019-08-22 18:05:14 UTC
(It's been posted on Phabricator as D23358) 

So hopefully that's helpful. If not, let me know the best practice for patches in the future.