Bug 411158 - New tab button gone missing (regression)
Summary: New tab button gone missing (regression)
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: tabbar (show other bugs)
Version: 19.08.0
Platform: Debian unstable Linux
: HI normal
Target Milestone: ---
Assignee: Mariusz Glebocki
URL:
Keywords: regression, usability
: 411379 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-08-22 10:34 UTC by Alex Hermann
Modified: 2019-09-29 14:39 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 19.12


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Hermann 2019-08-22 10:34:49 UTC
SUMMARY

I upgraded konsole from 18.04.0 to 19.08.0 (via Debian packages). In the updated version the "new tab" button/dropdown is gone and I can't seem to get it back.

The "close tab" button was also gone, but that one I got back by changing the "Show Close Tab button" setting.

STEPS TO REPRODUCE
1. Start konsole
2. Notice there is no "new tab" button
3. Panic!

OBSERVED RESULT
No "New tab" button


EXPECTED RESULT
New tab" button on the left of the tabbar.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)

There is no such thing as "About System"

KDE Plasma Version: 
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION
Comment 1 Alex Hermann 2019-08-22 10:45:40 UTC
Further investigation shows there (now?) exists a "NewTabButton" setting. It seems to have no GUI for it. The default value is false, breaking existing setups where the "new tab" button was shown before the upgrade.

Manually setting "NewTabButton" to true in ~/.config/konsolerc returns the button to the tabbar.

IMHO, still needs a GUI option and the value should default to the previous setting/default the user had.
Comment 2 Nate Graham 2019-08-23 18:56:49 UTC
Yikes, it looks like this got lost in https://cgit.kde.org/konsole.git/commit/?id=a8ec9ad28adfca9cb64252b965c3da2d3f1a634b
Comment 3 Kurt Hindenburg 2019-08-24 02:26:57 UTC
I'm not clear if removing it was on purpose or not.  Is there any reason the menu can't be used here?
Comment 4 Nate Graham 2019-08-24 02:40:52 UTC
The menu can be used. But in general I think it's poor code hygiene to leave a feature in but remove the UI to configure it; it will bit-rot because nobody uses it. IMO we should restore the configuration UI that allows the button to be shown on the tab bar, or we should remove the feature entirely. I would lean towards the former.
Comment 5 Mariusz Glebocki 2019-08-25 13:13:31 UTC
Not intentional. Fix:
https://invent.kde.org/kde/konsole/merge_requests/24
Comment 6 Kurt Hindenburg 2019-08-25 14:19:14 UTC
Git commit 616f5554b11b0420cfdd976382ff9d4f2d9f4a6a by Kurt Hindenburg, on behalf of Mariusz Glebocki.
Committed on 25/08/2019 at 14:18.
Pushed by hindenburg into branch 'master'.

Restore "Show 'new tab' button" option in Konsole Settings
FIXED-IN: 19.12

https://invent.kde.org/kde/konsole/merge_requests/24

M  +10   -3    src/settings/TabBarSettings.ui

https://invent.kde.org/kde/konsole/commit/616f5554b11b0420cfdd976382ff9d4f2d9f4a6a
Comment 7 Kurt Hindenburg 2019-08-25 14:19:17 UTC
Git commit 616f5554b11b0420cfdd976382ff9d4f2d9f4a6a by Kurt Hindenburg, on behalf of Mariusz Glebocki.
Committed on 25/08/2019 at 14:18.
Pushed by scmsync into branch 'master'.

Restore "Show 'new tab' button" option in Konsole Settings
FIXED-IN: 19.12

https://invent.kde.org/kde/konsole/merge_requests/24

M  +10   -3    src/settings/TabBarSettings.ui

https://commits.kde.org/konsole/616f5554b11b0420cfdd976382ff9d4f2d9f4a6a
Comment 8 Kurt Hindenburg 2019-08-25 14:19:46 UTC
I'd like to backport this to 19.08.1 but it will add a string.  Thoughts?
Comment 9 Nate Graham 2019-08-25 15:05:52 UTC
In principle it seems reasonable to me. Might want to give the translators a heads-up about it. Then again, if it re-adds the old string without changing anything, then there actually aren't any new strings so there's no problem.
Comment 10 Kurt Hindenburg 2019-08-25 15:34:12 UTC
not sure how Konsole-devel ml isn't on this
Comment 11 Kurt Hindenburg 2019-08-25 16:07:08 UTC
Git commit f780383096c1bc2b4ffe684a2a67013781dc2027 by Kurt Hindenburg.
Committed on 25/08/2019 at 16:06.
Pushed by hindenburg into branch 'Applications/19.08'.

Restore "Show 'new tab' button" option in Konsole Settings

This was inadvertedly removed in 19.08; re-add it even though it might
add a new string.
FIXED-IN: 19.08.1

CCMAIL: kde-i18n-doc@kde.org
GUI:

https://invent.kde.org/kde/konsole/merge_requests/24

M  +11   -4    src/settings/TabBarSettings.ui

https://invent.kde.org/kde/konsole/commit/f780383096c1bc2b4ffe684a2a67013781dc2027
Comment 12 Kurt Hindenburg 2019-08-25 16:07:10 UTC
Git commit f780383096c1bc2b4ffe684a2a67013781dc2027 by Kurt Hindenburg.
Committed on 25/08/2019 at 16:06.
Pushed by scmsync into branch 'Applications/19.08'.

Restore "Show 'new tab' button" option in Konsole Settings

This was inadvertedly removed in 19.08; re-add it even though it might
add a new string.
FIXED-IN: 19.08.1

CCMAIL: kde-i18n-doc@kde.org
GUI:

https://invent.kde.org/kde/konsole/merge_requests/24

M  +11   -4    src/settings/TabBarSettings.ui

https://commits.kde.org/konsole/f780383096c1bc2b4ffe684a2a67013781dc2027
Comment 13 Alex Hermann 2019-08-26 08:18:04 UTC
Thank you all for the quick responses and fix.
Comment 14 Burkhard Lück 2019-08-29 05:01:30 UTC
*** Bug 411379 has been marked as a duplicate of this bug. ***