Bug 411112 - Cuttlefish provides two AppStream IDs
Summary: Cuttlefish provides two AppStream IDs
Status: RESOLVED FIXED
Alias: None
Product: Plasma SDK
Classification: Plasma
Component: cuttlefish (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-20 18:31 UTC by Nate Graham
Modified: 2019-08-20 18:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.5


Attachments
Two Cuttlefishes in Discover (84.69 KB, image/png)
2019-08-20 18:31 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-08-20 18:31:40 UTC
Created attachment 122265 [details]
Two Cuttlefishes in Discover

Manjaro with Qt 5.13 and all KDE stuff built from git master.

Cuttlefish specifies two AppStream IDs:

~/kde/src/plasma-sdk$  (master) grep -r "org.kde.plasma.cuttlefish" | wc -l
5
~/kde/src/plasma-sdk$  (master) grep -r "org.kde.cuttlefish.desktop" | wc -l
2


This causes Cuttlefish to appear twice in AppStream lists:

appstreamcli search cuttlefish
Identifier: org.kde.plasma.cuttlefish [generic]
Name: Cuttlefish
Summary: List and preview available icons
Package: plasma-sdk
Homepage: http://kde.org
Icon: plasma-sdk_cuttlefish.png
---
Identifier: org.kde.cuttlefish.desktop [desktop-application]
Name: Cuttlefish
Summary: Icon Previewer for Artists and Developers
Package: plasma-sdk
Icon: plasma-sdk_cuttlefish.png


...which causes it to appear twice in Software center apps like Discover (see attached screenshot).

Looks like it needs to standardize on just one.
Comment 1 Nate Graham 2019-08-20 18:39:04 UTC
Git commit 06912303ea4bfbf5625e00a5b03f4fd72415b8b7 by Nate Graham.
Committed on 20/08/2019 at 18:38.
Pushed by ngraham into branch 'Plasma/5.16'.

[Cuttlefish] Use only a single AppStream ID

Summary:
Right now Cuttlefish provides both `org.kde.plasma.cuttlefish` and
`org.kde.cuttlefish.desktop` AppStream IDs, causing it to appear twice in Discover and
other software center apps.

This patch standardizes on `org.kde.plasma.cuttlefish`, and provides a compatibility
shim so you can still access it from the old URL (appstream://org.kde.cuttlefish.desktop)
FIXED-IN: 5.16.5

Test Plan: Don't know how to test this

Reviewers: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23301

M  +4    -1    cuttlefish/org.kde.cuttlefish.appdata.xml

https://commits.kde.org/plasma-sdk/06912303ea4bfbf5625e00a5b03f4fd72415b8b7