Bug 411073 - Scale preview popup according to icon size
Summary: Scale preview popup according to icon size
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.16.4
Platform: Kubuntu Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-19 17:11 UTC by Thiago Sueto
Modified: 2019-09-01 15:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Sueto 2019-08-19 17:11:22 UTC
SUMMARY
I use the Folder View widget at work to access the Documents and Downloads folder as well as samba share'd folders to have quick access to files without opening Dolphin.
As such, the folder preview popup feature where you click an upwards arrow to access the folders inside the widget's standard folders is really useful; I make this widget use almost the entire screen space of the laptop while I work on a full HD monitor. I also scaled folder icons according to each folder.
However, the arrow pointing upwards is not scaled with icon size and is pretty small, requiring really precise mouse movement and clicks. It seems to occupy about 2% of each folder icon when they're at their maximum size. I think it would be more convenient if it was bigger.
Comment 1 Nate Graham 2019-08-23 20:49:18 UTC
Not hard to do, and a reasonable UI improvement. Here's a patch: https://phabricator.kde.org/D23387

But I wonder:
> I make this widget use almost the entire screen space of the laptop while
> I work on a full HD monitor.
Wouldn't it be both faster and more convenient to click or double-click on the folder to open it in Dolphin, rather than using a Folder View popup as a file manager?
Comment 2 Thiago Sueto 2019-08-27 02:21:41 UTC
Hello Nate!
> Wouldn't it be both faster and more convenient to click or double-click on the folder to open it
> in Dolphin, rather than using a Folder View popup as a file manager?
That was a fairly recent experiment of mine that ended up working fairly well for me. The point of this is so that Dolphin would not appear when I'm alt-tabbing, while also keeping folders almost immediately accessible. But it's true, now that I think about it, this could also be achieved with window rules or virtual desktops. This was by all means a niche use-case, perhaps unintended behavior as well, I simply mentioned this to demonstrate a use-case for the preview popup.
Comment 3 Nate Graham 2019-08-27 17:17:39 UTC
Regardless, your original suggestion still makes sense. :)
Comment 4 Nate Graham 2019-09-01 15:10:32 UTC
Git commit d9ea98a61c7f83948a3e6ad09baf91a2be605dda by Nate Graham.
Committed on 01/09/2019 at 15:10.
Pushed by ngraham into branch 'master'.

[Folder view] Scale selection and preview buttons with item size

Summary:
Right now the selection and preview buttons that appear on hover are very very tiny,
and remain very very tiny even when the icon size is large.

This patch increases the size--and therefore visibility and clickability--of the buttons
as the icon size increases.
FIXED-IN: 5.17.0

Test Plan:
No change for icon sizes at slider positions 1, 2, and 3, where items are quite small.

Slider position 4: {F7274552, size-full}

Slider position 5: {F7274551, size=full}

Slider position 6: {F7305204, size=full}

Reviewers: hein, #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23387

M  +14   -1    containments/desktop/package/contents/ui/FolderItemActionButton.qml

https://commits.kde.org/plasma-desktop/d9ea98a61c7f83948a3e6ad09baf91a2be605dda