Bug 411007 - [Regression]: MinimizeAll minimizes windows on all virtual desktops instead of only the active one
Summary: [Regression]: MinimizeAll minimizes windows on all virtual desktops instead o...
Status: CONFIRMED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.16.2
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-17 11:22 UTC by imaginator
Modified: 2021-03-10 22:01 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description imaginator 2019-08-17 11:22:47 UTC
In Plasma-5.16.2 MinimizeAll minimizes the windows on all virtual desktops instead of just on the active one. 

This is not the case in Plasma-5.12.8/-5.13.5 (QT-5.10.1/Frameworks-5.46.0).

The expected/desired behaviour is that only the windows on the active desktop are minimized.


***
Plasma-5.16.2
Frameworks-5.60.0
QT-5.12.3
Comment 1 imaginator 2019-08-20 09:22:40 UTC
OK, the regression pertains to the *plasmoid* MinimizeAll.

The kwin script minimizeall works as expected.
Comment 2 Kai Uwe Broulik 2019-08-20 09:40:52 UTC
The code is meant to disengage minimize all mode when you switch virtual desktops or activities. However, it doesn't work because TasksModel doesn't track virtual desktops or activities on its own.

Unfortunately, when I fix that, you switch a virtual desktop, it then unminimizes the windows on the now other virutal desktop and KWin moves focus back to whatever window got focuses on that other desktop as a result of unminimizing and switches desktops back...
Comment 3 imaginator 2019-08-20 10:19:00 UTC
(In reply to Kai Uwe Broulik from comment #2)
> The code is meant to disengage minimize all mode when you switch virtual
> desktops or activities. However, it doesn't work because TasksModel doesn't
> track virtual desktops or activities on its own.
> 

I see. So something has changed in QT or FW?. It has worked before after all.

> Unfortunately, when I fix that, you switch a virtual desktop, it then
> unminimizes the windows on the now other virutal desktop and KWin moves
> focus back to whatever window got focuses on that other desktop as a result
> of unminimizing and switches desktops back...

I really hope you can figure out a solution. Perhaps the script might give you a clue. 

The script provides a keyboard shortcut. But unfortunately I haven't yet found a way to bind it to a button that could replace the plasmoid in the control panel.
Comment 4 Kai Uwe Broulik 2019-08-20 10:57:58 UTC
> So something has changed in QT or FW?.

It got ported from KWindowSystem to libtaskmanager so it works on Wayland
Comment 5 imaginator 2019-08-22 09:37:16 UTC
(In reply to Kai Uwe Broulik from comment #4)
> > So something has changed in QT or FW?.
> 
> It got ported from KWindowSystem to libtaskmanager so it works on Wayland

So it does work on Wayland?

If so and if you can't find a better way and if possible at all, you might provisionally fix this with something like 

if (wayland)
	wayland_code;
X11_code;


Using the kwin script might be an alternative - if that still works on Wayland.


BTW: the icon in the controlpanel is too small now.
Comment 6 imaginator 2019-09-13 10:02:57 UTC
(In reply to Kai Uwe Broulik from comment #4)
> > So something has changed in QT or FW?.
> 
> It got ported from KWindowSystem to libtaskmanager so it works on Wayland

If you can't see a way to solve this within a reasonable time-frame, you should imo consider withdrawing the plasmoid. The majority of installations probably still runs under X and this new behaviour is so confusingly different that it does more harm than good to the user. I already switched back to the Plasma-5.12-branch.
Comment 7 Patrick Silva 2019-09-21 15:44:56 UTC
I have just noticed the same bug on Wayland.

bug 410084 seems related.

Operating System: Arch Linux 
KDE Plasma Version: 5.16.90
KDE Frameworks Version: 5.62.0
Qt Version: 5.13.1
Comment 8 imaginator 2019-09-23 11:06:09 UTC
(In reply to Patrick Silva from comment #7)
> I have just noticed the same bug on Wayland.

So it's broken - irrespective of the display server protocol.

What's left is kwin's MinimizeAll. Do you know a way to bind this to a button that one could use instead of the plasmoid?
Comment 9 imaginator 2020-01-24 13:19:04 UTC
To no surprise the problem still exists in Plasma-5.17.5 and 5.18beta. For me it's a real bummer, so I'll stick with 5.12.9 as long as possible.

On a more general note: "Have you written a bug report?" is often used in discussions to counter criticism. In some cases perhaps rightly so. But from the perspective of people who *have* written reports even more frustratin than the bug itself is when a *confirmed* bug is not being properly addressed. This may save developers some hours in the short run but over time inevitably leads to erosion of support and allegiance. 

So don't expect me to again waste my time on writing reports against stable or beta-versions of Plasma, Frameworks or what have you. Or to ask anybody to do so.
Comment 10 imaginator 2020-01-30 09:29:36 UTC
Found a crude but effective workaround: simply copied the 5.12.9-version plus its module to 5.17.5. Works like it should with X, don't know about Wayland.

To the devs here: re-install the working version for 5.18.0 until you have a fix for this one. This buggy thing here is an imposition.

And mind: those who actually *write* a bug-report are just the tip of the iceberg of users affected (and peeved).