Bug 410912 - Improve "Move to album" for keyboard use
Summary: Improve "Move to album" for keyboard use
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Keyboard (show other bugs)
Version: 6.2.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-14 21:17 UTC by Kusi
Modified: 2019-08-16 21:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kusi 2019-08-14 21:17:35 UTC
SUMMARY

When the "Move to album" dialog is used by keyboard, there are some smaller usability issues

When launching the dialog, the ok button is focused, and the most recently chosen album is (passively) selected. When hitting the enter key, the move to the passively selected folder is performed.

However, the focused ok button does not accept any other keyboard inputs. A better solution is to initially focus on the search edit box. Apparently, when the dialog is launched, the search box is empty and enter is pressed, the move is still executed to the passively selected folder, which is good.

When the search edit box is selected, and you search a target folder, and you select a folder by move down arrow, and launch the move by pressing enter, the previously chosen folder is ignored, since apparently the selection of the album tree view has precedence. This is not what the user wanted: If the folder selection happens via search edit box, this selection has to be respected

Ideally, when you type half of the album name and the desired album appears on the first place on the drop down, you can press enter and the photo is moved the the first album on the drop down. But I believe that's not possible anymore since the move from KCompleter to QCompleter.

Furthermore, if the empty search edit box is focused (what should be the initial state) and the up/down key is hit, the album tree view should be focused and accept the up/down movement. This rule only applies if the search edit box is empty.


STEPS TO REPRODUCE (This only applies if "Move to album" is indeed only available via keyboard shortcut, I didn't find a menu entry for this action?)
1. Settings->Configure Shortcuts
2. Move to Album... -> Shortcut M -> ok
3. Select a photo
4. press M

OBSERVED RESULT
"ok" is focused


EXPECTED RESULT
- search edit box is focused
- respect folder chosen via typed text in the search edit box
Comment 1 Maik Qualmann 2019-08-16 10:36:47 UTC
Git commit 2d465a4ef2a918d605bc31557556023c70fec117 by Maik Qualmann.
Committed on 16/08/2019 at 10:35.
Pushed by mqualmann into branch 'master'.

add selection from completer to the album tree view
FIXED-IN: 6.3.0

M  +2    -1    NEWS
M  +4    -1    core/libs/album/widgets/albumselectdialog.cpp
M  +40   -2    core/libs/album/widgets/albumselectwidget.cpp
M  +5    -1    core/libs/album/widgets/albumselectwidget.h
M  +19   -0    core/libs/widgets/common/modelcompleter.cpp
M  +6    -0    core/libs/widgets/common/modelcompleter.h
M  +6    -0    core/libs/widgets/common/searchtextbar.cpp
M  +2    -0    core/libs/widgets/common/searchtextbar.h

https://invent.kde.org/kde/digikam/commit/2d465a4ef2a918d605bc31557556023c70fec117
Comment 2 Kusi 2019-08-16 21:57:17 UTC
Thanks Maik for the super fast fix!