Bug 410907 - The tab caption grows longer each time one does a git commit (using vi)
Summary: The tab caption grows longer each time one does a git commit (using vi)
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: tabbar (show other bugs)
Version: 19.04.3
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-14 18:34 UTC by Tobias Leupold
Modified: 2020-11-05 07:44 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
attachment-32165-0.html (974 bytes, text/html)
2020-11-05 07:09 UTC, Justin Zobel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Leupold 2019-08-14 18:34:19 UTC
When I work on a git repository using konsole, the tab's text grows each time I do a commit (using vi). One can easily reproduce this having the default "%d : %n : %w" template for the tab text set as follows:

    $ mkdir foo
    $ git init
    $ touch bar
    $ git add bar

Konsole's tab name is currently "foo : bash :", as it should be. Now commit the change:

    $ git commit -a

Enter a commit message and do :x. Konsole's tab name is now "foo : bash : foo : bash :"

One more "foo : bash :" is added with each commit.

Surely not a severe bug, but it sucks as soon as the tab's name is so long that a second tab is not visible anymore ;-)
Comment 1 Tobias Leupold 2019-08-15 05:54:34 UTC
(of course, you'll have to cd into the foo directory before running git init :-P)
Comment 2 Kurt Hindenburg 2019-08-18 22:00:42 UTC
I can't duplicate in 19.08 nor master - a lot has changed since 19.04
Comment 3 Tobias Leupold 2019-08-19 05:41:41 UTC
19.08 behaves in the very same way here with "%d : %n : %w" set.
Comment 4 Justin Zobel 2020-11-05 06:55:57 UTC
I can't replicate this with the default tab naming convention on konsole from git master.

Tobias, can you please test and confirm if the issue is still persisting for you, thanks.
Comment 5 Tobias Leupold 2020-11-05 07:03:17 UTC
The default is "%d : %n". It does not happwn with this setting. Most probably, it's about the "%w" flag ...
Comment 6 Justin Zobel 2020-11-05 07:08:35 UTC
(In reply to Tobias Leupold from comment #5)
> The default is "%d : %n". It does not happwn with this setting. Most
> probably, it's about the "%w" flag ...

Just tested with %w added and it still doesn't keep adding to the tab name. Can you please test and confirm Tobias?
Comment 7 Justin Zobel 2020-11-05 07:09:30 UTC
Created attachment 133046 [details]
attachment-32165-0.html

Note I was using nano to do commit messages. It may be a bug with vi, if it
is still the case.

On Thu, Nov 5, 2020 at 5:33 PM Tobias Leupold <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=410907
>
> --- Comment #5 from Tobias Leupold <tobias.leupold@gmx.de> ---
> The default is "%d : %n". It does not happwn with this setting. Most
> probably,
> it's about the "%w" flag ...
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
Comment 8 Tobias Leupold 2020-11-05 07:42:50 UTC
I just tried it the very same way I described in the initial bug report (also using vi, but I'm pretty sure that it it/was no vi bug). Apparently, this has been fixed meanwhile. The tab's name doesn't grow any longer anymore.

I switched back to "%d : %n" back then and didn't try "%w" until today, so I can't tell when it was fixed. But apparently, it was :-)