Bug 410854 - Monochrome "computer" icon is used no matter what icon resolution is used
Summary: Monochrome "computer" icon is used no matter what icon resolution is used
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-12 15:45 UTC by Efe Ciftci
Modified: 2019-08-26 18:26 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
A screenshot which shows how monochrome "computer" icon is used in higher icon resolutions (114.35 KB, image/png)
2019-08-12 15:45 UTC, Efe Ciftci
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Efe Ciftci 2019-08-12 15:45:44 UTC
Created attachment 122088 [details]
A screenshot which shows how monochrome "computer" icon is used in higher icon resolutions

SUMMARY
There are two variations of "computer" icon in Breeze icon theme: a monochrome icon for 16x16 and 22x22 resolutions and a colorful icon for 32x32 and higher resolutions. The "computer" icon stays monochrome no matter what zoom level is used. Tested with Dolphin (places panel, folder contents) and Desktop.

STEPS TO REPRODUCE
1a. Choose "Create New" -> "Link to Application" in Dolphin/Desktop
or;
1b. Choose "Add Entry" in Dolphin places panel
2. From the list to choose an icon, select "Devices" -> "computer"
3. Accept changes by clicking OK to close the properties window.

OBSERVED RESULT
The newly created link displays monochrome "computer" icon in all icon resolutions (16x16, 22x22, 32x32, 48x48...)

EXPECTED RESULT
The newly created link should display monochrome "computer" icon only in 16x16 and 22x22 icon resolutions and colorful "computer" icon in resolutions 32x32 and higher.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 5.16
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.12.3
Comment 1 Nate Graham 2019-08-12 23:26:08 UTC
Confirmed, that's very odd. You can see the issue in Cuttlefish, too. Maybe some kind of conflict with the Plasma theme icon with the same name?
Comment 2 Noah Davis 2019-08-15 04:25:11 UTC
(In reply to Nate Graham from comment #1)
> Confirmed, that's very odd. You can see the issue in Cuttlefish, too. Maybe
> some kind of conflict with the Plasma theme icon with the same name?

The cuttlefish issue is because of the Plasma theme, but I don't know why Dolphin is having an issue. I can't reproduce the Dolphin issue either.
Comment 3 Efe Ciftci 2019-08-25 10:08:24 UTC
(In reply to Noah Davis from comment #2)
> I can't reproduce the Dolphin issue either.

Contents of a minimal .desktop file that represents this bug is as follows:
[Desktop Entry]
Icon=computer

This file will be listed as the monochrome computer icon in Dolphin in all display resolutions.

In the meanwhile, I think I've found a solution for this bug. By executing "find -iname '*computer*' in the icon directory, I've found out that a computer.svg (monochrome symlink) resides in applets/22 directory as well. The entry for applets/22 in index.theme is as follows:

#256x256 - Color for applets
[applets/22]
Size=22
Context=Status
Type=Scalable
MinSize=22
MaxSize=256

I'm not quite sure if it breaks something else, but I've modified this entry as follows; which has solved the problem for me:

#22x22 - Color for applets
[applets/22]
Size=22
Context=Status
Type=Fixed

It seems when the same icon resides in more than one category (actions, applications, categories...), the icon file in whichever directory it has been found first (in the order specified as by index.theme) is picked.
Comment 4 Noah Davis 2019-08-25 14:18:34 UTC
(In reply to Efe Ciftci from comment #3)
> (In reply to Noah Davis from comment #2)
> > I can't reproduce the Dolphin issue either.
> 
> Contents of a minimal .desktop file that represents this bug is as follows:
> [Desktop Entry]
> Icon=computer
> 
> This file will be listed as the monochrome computer icon in Dolphin in all
> display resolutions.
> 
> In the meanwhile, I think I've found a solution for this bug. By executing
> "find -iname '*computer*' in the icon directory, I've found out that a
> computer.svg (monochrome symlink) resides in applets/22 directory as well.
> The entry for applets/22 in index.theme is as follows:
> 
> #256x256 - Color for applets
> [applets/22]
> Size=22
> Context=Status
> Type=Scalable
> MinSize=22
> MaxSize=256
> 
> I'm not quite sure if it breaks something else, but I've modified this entry
> as follows; which has solved the problem for me:
> 
> #22x22 - Color for applets
> [applets/22]
> Size=22
> Context=Status
> Type=Fixed
> 
> It seems when the same icon resides in more than one category (actions,
> applications, categories...), the icon file in whichever directory it has
> been found first (in the order specified as by index.theme) is picked.

Ah yes, I can confirm it now. I'll write a patch to remove it since it's just a symlink to another 22px icon with the same exact name.
Comment 5 Noah Davis 2019-08-26 18:26:29 UTC
Git commit fff83c41653a90b9dadf8bd3eb3b2d57843d7d8d by Noah Davis.
Committed on 26/08/2019 at 18:26.
Pushed by ndavis into branch 'master'.

Remove applets/22/computer

Summary:

It's also unnecessary because it's just a symlink to another 22px icon with the same exact name.

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23444

D  +0    -1    icons-dark/applets/22/computer.svg
D  +0    -1    icons/applets/22/computer.svg

https://commits.kde.org/breeze-icons/fff83c41653a90b9dadf8bd3eb3b2d57843d7d8d