Bug 410801 - 'Switch user' button is cut off
Summary: 'Switch user' button is cut off
Status: RESOLVED FIXED
Alias: None
Product: kscreenlocker
Classification: Plasma
Component: breeze-theme (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-11 05:02 UTC by Kishore Gopalakrishnan
Modified: 2019-09-23 13:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.0


Attachments
Screenshot showing the issue (451.83 KB, image/png)
2019-08-11 05:02 UTC, Kishore Gopalakrishnan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2019-08-11 05:02:53 UTC
Created attachment 122056 [details]
Screenshot showing the issue

SUMMARY
The 'Switch users' button on the lock screen goes slightly out of the display area (see screenshot).

STEPS TO REPRODUCE
1. Lock screen

OBSERVED RESULT
'Swtich user' button is slightly out of the screen

EXPECTED RESULT
'Switch user' button should fit completely within the screen

SOFTWARE/OS VERSIONS
Distro: Arch Linux
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.60.0
Qt Version: 5.13.0

ADDITIONAL INFORMATION
My screen resolution is 1366x768. I don't have access to a larger display to check if it is reproducible there too. Bug is reproducible regardless of whether the media controls are enabled / disabled.
Comment 1 Kishore Gopalakrishnan 2019-09-09 15:11:25 UTC
I've submitted a patch here: https://phabricator.kde.org/D23786
Comment 2 Nate Graham 2019-09-23 13:29:42 UTC
Git commit cb96abf9c98f356c0c4befca3572d1080c9770ec by Nate Graham, on behalf of Kishore Gopalakrishnan.
Committed on 23/09/2019 at 13:27.
Pushed by ngraham into branch 'Plasma/5.17'.

Remove some spacing on lockscreen that was causing elements to get cut off on small displays

Summary:
This patch removes some spacing which was making the 'switch users' button get slightly cut off on small displays (1366x768). Quite a few old laptops have screens of this size, so it is good to take into account that display size as well, as long as it doesn't negatively affect the appearance for large displays.
FIXED-IN: 5.17.0

Test Plan:
Lock screen when connected to a low-res display and check that the 'switch users' button isn't cut off.

**Before this patch:**
Lockscreen on small display (1366x768): {F7330101}
Lockscreen on big display (1920x1080): {F7330096}

**After this patch:**
Lockscreen on small display (1366x768): {F7342190}
Lockscreen on big display (1920x1080): {F7342191}

Reviewers: #plasma, #vdg, ngraham, filipf

Reviewed By: #vdg, ngraham, filipf

Subscribers: filipf, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23786

M  +8    -0    lookandfeel/contents/lockscreen/LockScreenUi.qml

https://commits.kde.org/plasma-workspace/cb96abf9c98f356c0c4befca3572d1080c9770ec