Bug 410695 - Application launcher does not highlight when zoom factor is disabled
Summary: Application launcher does not highlight when zoom factor is disabled
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: 0.9.1
Platform: Kubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-07 13:21 UTC by G_v_I
Modified: 2019-08-08 20:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshots illustrating the issue. (620.35 KB, application/zip)
2019-08-08 07:15 UTC, G_v_I
Details
Latte layout file in use on the system displaying this issue. (1.25 KB, text/plain)
2019-08-08 07:17 UTC, G_v_I
Details
Video of issue. (1.82 MB, video/x-matroska)
2019-08-08 10:54 UTC, G_v_I
Details

Note You need to log in before you can comment on or make changes to this bug.
Description G_v_I 2019-08-07 13:21:09 UTC
SUMMARY
When Latte Dock is loaded, the button of the KDE application launcher is initially highlighted on hover, in the same way other buttons are. Yet Latte Dock then resizes the application launcher button to match the other buttons
in size, after which the button no longer animates: it always looks the same, irrespective of whether or not the user clicks or hovers over the button.

This did not used to happen prior to version 0.9 or 0.9.1 (sadly, I do not know exactly what version was installed on my system prior to the most recent update). The application launcher button animated correctly.

STEPS TO REPRODUCE
1. Add the standard KDE application launcher to the dock.
2. Reload the dock, whether by rebooting or logging off, and then logging on.

OBSERVED RESULT
The application launcher's button will initially be slightly larger than other launcher buttons, at which point it will still animate correctly. It is then resized by the dock, and subsequently cease to animate. 

EXPECTED RESULT
Button is the same size as the other launcher buttons from the start, and animates in the same way as the other launcher buttons do.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.60.0
Qt Version: 5.12.2

ADDITIONAL INFORMATION
Kubuntu 19.04, 4K screen resolution.
Comment 1 Michail Vourlakos 2019-08-07 13:26:02 UTC
I can not reproduce in my system,

1. Send your layout file
2. Send a screenshot demonstrating when it does not highlight
Comment 2 Michail Vourlakos 2019-08-07 13:27:56 UTC
3. Are you using plasma indicator style?
Comment 3 Michail Vourlakos 2019-08-08 06:49:08 UTC
Git commit 8a9224ed3c05b2df2b3e0d28308ba94ec109d7cb by Michail Vourlakos.
Committed on 08/08/2019 at 06:25.
Pushed by mvourlakos into branch 'v0.9'.

enable highlighting effect for plasma indicator

M  +1    -1    indicators/org.kde.latte.plasma/package/ui/main.qml

https://commits.kde.org/latte-dock/8a9224ed3c05b2df2b3e0d28308ba94ec109d7cb
Comment 4 Michail Vourlakos 2019-08-08 06:51:25 UTC
Git commit 2b9b95279d2457bec36d2c97f3371d8a56597ad8 by Michail Vourlakos.
Committed on 08/08/2019 at 06:51.
Pushed by mvourlakos into branch 'master'.

enable highlighting effect for plasma indicator

M  +1    -1    indicators/org.kde.latte.plasma/package/ui/main.qml

https://commits.kde.org/latte-dock/2b9b95279d2457bec36d2c97f3371d8a56597ad8
Comment 5 G_v_I 2019-08-08 07:00:25 UTC
Many thanks for making the necessary changes, and sorry about not replying to your requests - I noticed them only a moment ago.
Comment 6 G_v_I 2019-08-08 07:03:26 UTC
EDIT / Additional comment: I am using the Latte indicator style.

I will figure out how to share a layout file, and upload it here.
Comment 7 G_v_I 2019-08-08 07:15:07 UTC
Created attachment 122004 [details]
Screenshots illustrating the issue.
Comment 8 G_v_I 2019-08-08 07:17:42 UTC
Created attachment 122005 [details]
Latte layout file in use on the system displaying this issue.
Comment 9 Michail Vourlakos 2019-08-08 09:53:10 UTC
1. The layout you sent does not contain any application launcher at all
2. I added myself the default application launcher at the start and the issue can not reproduced in my system

You need to check the following:
A1: Are you sure you have not locked the application launcher to not use the parabolic effect? https://userbase.kde.org/LatteDock/FAQ#Can_I_disable_the_parabolic_effect_for_a_specific_applet.3F

A2: The icon you are using in your screenshots is not the default one. If you use another icon from breeze theme, do you have the same issue?

A3: If A1 AND A2 do not work, you need to send the right layout file that is the one you are using in your screenshots
Comment 10 G_v_I 2019-08-08 10:08:05 UTC
1. The file I uploaded is from .config/latte. Is there somewhere else I should look?

2. 

A1 - This is the 'zoom on hover' effect, right? I do not have it enabled. When I do enable it, however, everything works correctly: the application launcher button is hightlighted on hover and 'darkened' on click in the same way other buttons are. The button also increases in size if/when the mouse cursor hovers over it, as intended.

A2 - I have tried other buttons, including the default KDE one, but unfortunately the same thing happens.
Comment 11 G_v_I 2019-08-08 10:54:05 UTC
Created attachment 122009 [details]
Video of issue.

A short video showing how

1. Other launcher buttons highlight correctly, and will go dark when clicked.
2. The application launcher button does not respond in this way.
3. After logging off, then logging back in, the application launcher button will briefly respond as expected.
4. The dock buttons are then slightly resized by the dock/system and the situation goes back to what is described under (1) and (2).
Comment 12 Michail Vourlakos 2019-08-08 13:17:29 UTC
Yep I reproduced,

Unfortunately this is not solvable. When the user disables the zoom effect it disables also for all applets the hovering and clicked animations that are provided by Latte.
Comment 13 Michail Vourlakos 2019-08-08 13:44:27 UTC
Git commit 289429185b81653cd1fae2f98cd3131d86f3efe1 by Michail Vourlakos.
Committed on 08/08/2019 at 13:37.
Pushed by mvourlakos into branch 'v0.9'.

hacky flag to keep Latte behavior for zoom=1

--if some users want to keep the Latte specific behavior
when the zoom factor = 1 then it can just LOCK
these applets

M  +1    -1    containment/package/contents/ui/applet/AppletItem.qml

https://commits.kde.org/latte-dock/289429185b81653cd1fae2f98cd3131d86f3efe1
Comment 14 Michail Vourlakos 2019-08-08 13:45:03 UTC
Git commit 549628ddd0f0876f3e4bfc4bdb252a0022fb2782 by Michail Vourlakos.
Committed on 08/08/2019 at 13:44.
Pushed by mvourlakos into branch 'master'.

hacky flag to keep Latte behavior for zoom=1

--if some users want to keep the Latte specific behavior
when the zoom factor = 1 then it can just LOCK
these applets

M  +1    -1    containment/package/contents/ui/applet/AppletItem.qml

https://commits.kde.org/latte-dock/549628ddd0f0876f3e4bfc4bdb252a0022fb2782
Comment 15 Michail Vourlakos 2019-08-08 13:46:39 UTC
(In reply to G_v_I from comment #11)
> 

ok... the fix is the following. For those applets that you want to keep the original Latte behavior even when the zoom factor is disabled for those applets you can lock them from their tooltip.
Comment 16 G_v_I 2019-08-08 20:17:38 UTC
Thank you for fixing this!