Bug 410652 - Category icons should come from the icon theme, not the Plasma theme
Summary: Category icons should come from the icon theme, not the Plasma theme
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: master
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-06 14:24 UTC by Miroslav Spehar
Modified: 2023-08-01 03:37 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/7d1ede498e0157ab90b364d093d4d5690d201158
Version Fixed In: 6.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Spehar 2019-08-06 14:24:02 UTC 
SUMMARY
Changing icons theme in settings does not change category icons in Kickoff. This gets changed only when look-and-feel is changed.

STEPS TO REPRODUCE
1. Install papirus icon theme
2. Change icon theme 
3. Start Kickoff and verify that icons Favorites, Applications, Computer... have not been updated

OBSERVED RESULT
After changing icon theme, category icons in Kickoff are not updated

EXPECTED RESULT
After changing icon theme, category icons in Kickoff are used from the newly selected theme.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: arch
KDE Plasma Version: 5.16

ADDITIONAL INFORMATION
Same happens with Kicker
Comment 1 Nate Graham 2021-01-06 17:42:59 UTC 
This is intentional right now, but maybe it shouldn't be. Overall I don't really like the fact that Plasma themes have icons in them and I think the icon theme should control everything. Anything else is quite unpredictable and can cause difficulty achieving unified icon styling throughout the system.
Comment 2 laubblaeser 2021-04-28 23:03:46 UTC 
Absolutely agree with the points made here. Inconsistency in icon theming is a very annoying thing to deal with.
Comment 3 David Edmundson 2021-04-28 23:12:22 UTC 
>and I think the icon theme should control everything

That just replaces things with a dozen other bug reports about everyone's system tray looking like a rainbow, so it's not quite so trivial.


Kickoff category icons are changable without big refactors. It's just a case of adding

```
usesPlasmaTheme: false 
```

if we want it
Comment 4 Nate Graham 2021-04-29 16:41:37 UTC 
This comes from Purpose which is in Frameworks, and it was fixed recently!
Comment 5 Nate Graham 2021-04-29 16:42:41 UTC 
Oops, wrong bug.
Comment 6 Nate Graham 2021-05-06 02:31:00 UTC 
Actually, we have a somewhat longstanding request to do just that for the System Tray too: Bug 373087.

Maybe it's something we should *sigh* just make configurable.

Personally I don't see the need though. I don't really understand the use case of wanting to use colorful small action items in your apps, but have a totally different set of icons used in Plasma.
Comment 7 Nate Graham 2023-08-01 03:37:01 UTC 
This has been fixed for Plasma 6 by using Kirigami.Icon to draw all the icons in Kickoff, which always pulls from the Icon theme, not the Plasma theme.