Bug 410469 - konsole upgrade 19.04 -> 19.07 breaks QDBUS session support
Summary: konsole upgrade 19.04 -> 19.07 breaks QDBUS session support
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 19.07.80
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-31 19:15 UTC by pgnd
Modified: 2021-03-25 04:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pgnd 2019-07-31 19:15:31 UTC
on	

	lsb_release -rd
		Description:    openSUSE Leap 15.1
		Release:        15.1

with

	plasma5-workspace-devel-5.16.3-lp151.464.1.x86_64
	plasma-framework-devel-5.60.0-lp151.254.1.x86_64
	libQt5Core-devel-5.13.0-lp151.5.1.x86_64
	etc

after upgrade from

	konsole -v
		konsole 19.04.3

to

	konsole -v
		konsole 19.07.80

provided (currently) by

	konsole-19.07.80-lp151.1.1.x86_64

from
 repo @

	https://download.opensuse.org/repositories/KDE:/Applications/KDE_Frameworks5_openSUSE_Leap_15.1

all scripts that open/exec konsole sessions in new tabs, using qdbus,

	QDBUS="/usr/bin/qdbus-qt5"
	SVC=$( $QDBUS | grep -i org.kde.konsole )
	echo $SVC
	local session_num=$(${QDBUS} ${SVC} /Windows/1 newSession)
	${QDBUS} ${SVC} /Sessions/$session_num setTitle 0 test
	${QDBUS} ${SVC} /Sessions/$session_num setTitle 1 Shell
	${QDBUS} ${SVC} /Sessions/$session_num sendText 'clear; ssh @test.pgnd.lan'
	${QDBUS} ${SVC} /Sessions/$session_num sendText $'\n'
	${QDBUS} ${SVC} /Windows/1 prevSession

now fail.

there's no error I've (yet) found in journal.
just no new tabs are opened.

dropback to 

	konsole 19.04.3

*does* cure the issue -- new sessions/tabs are opened, as intended/expected.
Comment 1 Kurt Hindenburg 2019-08-04 20:35:55 UTC
You can use Konsole's variables which make this much easier

Example:
printenv | grep KONSOLE              
KONSOLE_DBUS_SERVICE=:1.405
KONSOLE_DBUS_SESSION=/Sessions/1
KONSOLE_DBUS_WINDOW=/Windows/1
KONSOLE_PROFILE_NAME=Solarized Light
KONSOLE_VERSION=190790


qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW prevSession
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_SESSION sendText hi

The only one that doesn't appear to work is newSession
Comment 2 Kurt Hindenburg 2019-08-04 21:13:14 UTC
This appears to fix newSession - needs to be done in all of the newSession

-    createView(session);
+    auto newView = createView(session);
+    activeContainer()->addView(newView);
     session->run();
Comment 3 Kurt Hindenburg 2019-08-05 14:13:57 UTC
Git commit 3824de3e4f07fccf3e49c74afe80298cd734e178 by Kurt Hindenburg.
Committed on 05/08/2019 at 14:12.
Pushed by hindenburg into branch 'master'.

Fix dbus newSession() three methods to work
FIXED-IN: 19.08

M  +6    -3    src/ViewManager.cpp

https://invent.kde.org/kde/konsole/commit/3824de3e4f07fccf3e49c74afe80298cd734e178
Comment 4 Kurt Hindenburg 2019-08-05 14:14:00 UTC
Git commit 3824de3e4f07fccf3e49c74afe80298cd734e178 by Kurt Hindenburg.
Committed on 05/08/2019 at 14:12.
Pushed by scmsync into branch 'master'.

Fix dbus newSession() three methods to work
FIXED-IN: 19.08

M  +6    -3    src/ViewManager.cpp

https://commits.kde.org/konsole/3824de3e4f07fccf3e49c74afe80298cd734e178
Comment 5 Kurt Hindenburg 2019-08-06 00:24:34 UTC
Git commit a3ec064f2f2af6a774d28ead9fb32e070cf06ea8 by Kurt Hindenburg.
Committed on 06/08/2019 at 00:22.
Pushed by hindenburg into branch 'Applications/19.08'.

Fix dbus newSession() three methods to work
FIXED-IN: 19.08
(cherry picked from commit 3824de3e4f07fccf3e49c74afe80298cd734e178)

M  +6    -3    src/ViewManager.cpp

https://invent.kde.org/kde/konsole/commit/a3ec064f2f2af6a774d28ead9fb32e070cf06ea8
Comment 6 Kurt Hindenburg 2019-08-06 00:24:40 UTC
Git commit a3ec064f2f2af6a774d28ead9fb32e070cf06ea8 by Kurt Hindenburg.
Committed on 06/08/2019 at 00:22.
Pushed by scmsync into branch 'Applications/19.08'.

Fix dbus newSession() three methods to work
FIXED-IN: 19.08
(cherry picked from commit 3824de3e4f07fccf3e49c74afe80298cd734e178)

M  +6    -3    src/ViewManager.cpp

https://commits.kde.org/konsole/a3ec064f2f2af6a774d28ead9fb32e070cf06ea8
Comment 7 Kurt Hindenburg 2021-03-25 04:17:09 UTC
Resolving this as the earlier commits should have fixed this.