Bug 410339 - ‘Spot’ string needs message context
Summary: ‘Spot’ string needs message context
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Translation (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Karl Ove Hufthammer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-29 08:01 UTC by Karl Ove Hufthammer
Modified: 2019-07-29 09:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Ove Hufthammer 2019-07-29 08:01:46 UTC
SUMMARY
The string ‘Spot’ appears two places in the UI: In the palette editor and in the Exif editor. But the meaning is different. In the first case, it refers to a spot colour, and in the second, to spot-based autofocus.

The translations need to be different for the two meanings. That’s currently not possible, as there is only one ‘Spot’ string in the POT file. So at least one of the strings needs have a ‘msgctxt’ added, *or* they must be reworded to no longer be identical (perhaps the first one can be changed to ‘Spot color’?).
Comment 1 Karl Ove Hufthammer 2019-07-29 09:36:55 UTC
I can try to fix this one.
Comment 2 Halla Rempt 2019-07-29 09:50:54 UTC
okay :-)
Comment 3 Karl Ove Hufthammer 2019-07-29 09:59:47 UTC
Git commit d1ced644fabf052a67f486f7953ebf4c415572ce by Karl Ove Hufthammer.
Committed on 29/07/2019 at 09:52.
Pushed by rempt into branch 'master'.

Disambiguate ‘Spot’ strings for translation

Adds a ‘msgctxt’ for the ‘Spot’ autofocus metering mode string
in the Exif editor, so that it can have a different translation
than other ‘Spot’ (colour) strings. Also changes the ‘Spot’
string in the palette editor to ‘Spot color’, to make it
clearer what the checkbox does.

M  +1    -1    libs/ui/KisPaletteEditor.cpp
M  +1    -1    plugins/extensions/metadataeditor/editors/exif.ui

https://invent.kde.org/kde/krita/commit/d1ced644fabf052a67f486f7953ebf4c415572ce