Bug 410221 - "Scan for Faces" ("Nach Gesichtern suchen") for an album with nested sub-albums doesn't scan sub-albums.
Summary: "Scan for Faces" ("Nach Gesichtern suchen") for an album with nested sub-albu...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 6.1.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-26 07:45 UTC by spam-receiver
Modified: 2019-07-26 17:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description spam-receiver 2019-07-26 07:45:59 UTC
SUMMARY
"Scan for Faces" ("Nach Gesichtern suchen") for an album with nested sub-albums doesn't scan sub-albums.

STEPS TO REPRODUCE
1. In "Album view" select an album with zero enries but with sub-albums.
2. For this album click "Scan for faces" ("Nach Gesichtern suchen") in the context menu.

OBSERVED RESULT
The album and all of its sub-albums should be scanned for faces.

EXPECTED RESULT
Only the album itself (which is empty - zero entries) is scanned and the scanning process terminates immediately - without any results, of course.

SOFTWARE/OS VERSIONS
Windows: Win10 x64
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

Found in DigiKam 6.1.0

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2019-07-26 08:06:16 UTC
It is not intended to scan all sub-albums as well. This function is for fast scanning of currently selected album. You can select and scan the sub-albums in the "Peoble" tab in the album selection.

Alternatively, you can activate the display of sub-albums in the view and then select all items and scan for faces via the right mouse button menu.

Maik
Comment 2 spam-receiver 2019-07-26 08:51:14 UTC
(In reply to Maik Qualmann from comment #1)
> It is not intended to scan all sub-albums as well. This function is for fast
> scanning of currently selected album. You can select and scan the sub-albums
> in the "Peoble" tab in the album selection.

I don't know how to achieve this. In the "People" tab, the person's names are listed, not the albums. Thus, I can't select an album there.

> Alternatively, you can activate the display of sub-albums in the view and
> then select all items and scan for faces via the right mouse button menu.

I also am unable to achieve this. I can't select more than one album in the "Album" tab.
> Maik
Comment 3 Maik Qualmann 2019-07-26 10:29:25 UTC
People tab-> Scan collection for faces-> Options-> Albums tab

This is the "old" way that was only available so far.

Or:

Main menu-> view-> [x] include Album Sub-Tree

Now you can select in the Icon view the images to be scanned. Right-click-> search for faces

The automatic search in sub-albums would not be controllable, for users who do not want the sub-albums to be scanned. There is already a bug entry for the behavior that only one album can be selected in the album view.

Maik
Comment 4 spam-receiver 2019-07-26 11:01:24 UTC
(In reply to Maik Qualmann from comment #3)
> People tab-> Scan collection for faces-> Options-> Albums tab
> 
> This is the "old" way that was only available so far.

Ah, okay. This way is similar to the "Maintenace" window. As it is not very intuitive, addressing this as a workflow issue seems to me approriate.

And in this window as well as in the "Maintenance" window, I was not able to find an "include sub-albums" option to control the operation.


> Or:
> 
> Main menu-> view-> [x] include Album Sub-Tree
> 
> Now you can select in the Icon view the images to be scanned. Right-click->
> search for faces

I see. I already have set "[x] include Album Sub-Tree". So, when I click on an album, the entries of all sub-albums are displayed, too. Thus I expected that "Scan for faces" would use the same setting and scan all the displayed items.

I would use "Ctrl+A" to select all items, and right-click on one of the items rather than on the album?

Again, as above, I would like to address this as a workflow issue.


> 
> The automatic search in sub-albums would not be controllable, for users who
> do not want the sub-albums to be scanned. There is already a bug entry for
> the behavior that only one album can be selected in the album view.

The automatic search would be controllable via the "[x] include Album Sub-Tree" flag:

- When you select an album, depending on the setting you get either the pictures of the album itself or including the ones from the sub-albums.

- When you right-click on the same album and scan for faces, you would scan either the album itself or the album and its sub-folders, depending on the setting.

This way, the "Scan for faces" function follows the display function which is more intuitive than the current behaviour.


> 
> Maik
Comment 5 Maik Qualmann 2019-07-26 17:42:45 UTC
Git commit db1ab4d660f9861cbe24a2891e60a75d405e6e9c by Maik Qualmann.
Committed on 26/07/2019 at 17:41.
Pushed by mqualmann into branch 'master'.

we ask the user if scan in sub-albums
FIXED-IN: 6.2.0

M  +2    -3    NEWS
M  +16   -1    core/libs/album/treeview/albumselectiontreeview.cpp

https://invent.kde.org/kde/digikam/commit/db1ab4d660f9861cbe24a2891e60a75d405e6e9c