Bug 410095 - Messaging app appears to be loading forever if the number of messages in the complete conversation do not fill the initial view
Summary: Messaging app appears to be loading forever if the number of messages in the ...
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: messaging-application (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources All
: NOR normal
Target Milestone: ---
Assignee: Simon Redman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-22 07:13 UTC by Simon Redman
Modified: 2019-07-29 20:15 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 2e04adf99ce6bf6b6c50376497115b4e0efec4e4
Sentry Crash Report:
simon: Usability+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Redman 2019-07-22 07:13:27 UTC
SUMMARY
Messaging app appears to be loading forever if the number of messages in the complete conversation do not fill the initial view

The basic issue is that there is no response from the daemon if the phone sends back an empty list of messages, so there is no way to know that "that's it"

The damage is minimal since we are still able to send messages while loading (so we can still see all messages in the conversation and interact with it). It is just a confusing UI.

STEPS TO REPRODUCE
1. Open a short conversation in the messaging app (for example, one message)
2. See loading indicator forever

OBSERVED RESULT
Messages still appear to be loading even though none are there

EXPECTED RESULT
Remove the loading indicator to indicate that all messages have been loaded

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 29
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.58.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION
Consider the two problem cases: A conversation with only one message (so asking the phone for more results in an empty list) and a conversation with only a few messages (so asking the daemon for 10 messages gives back fewer than 10)

Probably the correct answer to this situation is to move the handling of `isInitalized` from the QML view to the C++ model so that it's possible to connect the reply from the daemon to the logic controlling the view