Bug 410075 - Combine the two options "View all accounts" and "Hide closed" accounts
Summary: Combine the two options "View all accounts" and "Hide closed" accounts
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 5.0.5
Platform: Other Linux
: LO wishlist
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2019-07-21 15:52 UTC by Martin Steigerwald
Modified: 2024-07-14 13:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Steigerwald 2019-07-21 15:52:07 UTC
SUMMARY

Since KMyMoney closed accounts are shown with name and amount crossed out even tough in Settings / General / Filter I set "do not show closed accounts" (translated back from German translation so actually wording might be different). In previous versions they were really hidden.

STEPS TO REPRODUCE
1. Close an account.
2. Set "do not show closed accounts" in Settings / General / Filter

OBSERVED RESULT

In account view the closed account is still shown, but with name and amount crossed out.

EXPECTED RESULT

They are hidden like before.

Why?

- They clutter the account overview.
- I do not access them anymore on a regular base. They are just there in case I need to review a transaction from that time.
- The closed accounts are a thing of the past, I do not need KMyMoney remind me of their previous existence every time I use it.
- In the overview dashboard they are still hidden. All closed accounts have a balance of zero.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian Sid
KDE Plasma Version: still 5.14
KDE Frameworks Version: still 5.54
Qt Version: 5.11.3
Comment 1 Thomas Baumgart 2019-07-21 19:49:18 UTC
What is the setting of "View/Show all accounts"? In case selcted, deselect it and the hidden accounts should disappear.
Comment 2 Martin Steigerwald 2019-07-21 21:18:09 UTC
"View/Show all accounts" in "Display" menu was set to "View all accounts".

That explains it. Thus closing as not a bug. Thank you.

A bit puzzling tough to have two settings that somehow contradict each other.
Comment 3 Jack 2019-07-21 23:30:07 UTC
I believe we recently discussed this, but I don't remember if it was another bug filed, or just on the mailing list.  I've made a note to be sure the manual is sufficiently clear about it - in both places that describe the two relevant settings.  I may also add it to the FAQ.  You are correct that it is not really intuitive how those two settings combine, and even more confusing if you have only discovered one of them so far.
Comment 4 Thomas Baumgart 2019-07-22 05:45:57 UTC
The default for "View all accounts" is off:

  <entry name="ShowAllAccounts" type="Bool">                                     
   <label>Show all accounts</label>                                              
   <default>false</default>                                                      
  </entry>                                                                       

So is "Hide closed accounts":

  <entry name="HideClosedAccounts" type="Bool">                                  
   <label>Hide closed accounts</label>                                           
   <default>false</default>                                                      
  </entry>                                                                       

The user must have found both and played with it if any of them is set :)

Looking at the code, I am tempted to combine the two into one in a future release. Any objections?
Comment 5 Martin Steigerwald 2019-07-22 06:30:31 UTC
(In reply to Thomas Baumgart from comment #4)
> The default for "View all accounts" is off:
[…]
> So is "Hide closed accounts":
[…]
> The user must have found both and played with it if any of them is set :)

Thing is: finding them both does not guarantee remembering them. Especially when the user found one and only at a later time the other and between both findings there was a year or so :)

> Looking at the code, I am tempted to combine the two into one in a future
> release. Any objections?

Not from me. Reopening as a wish list bug with different title.

Maybe directly within the "View" menu for easy discoverability? On the other hand the option may not be used all that much.
Comment 6 Jack 2019-07-22 14:29:23 UTC
I actually do use it fairly often.  I have many old accounts of various sorts closed.  Unfortunately, I seem to need to modify transactions in those accounts on occasion, and have to reopen the account to edit the transaction and then close the account.  If closed accounts are not shown, I need to toggle the display, make my edit, and then toggle again.

So, I agree with having only a single place to control this, but we should think carefully about the wording.  Here I am less concerned with new users than with existing users who need to toggle the view, and only remember one or the other of the old settings, but not both.  We should also definitely retain a keyboard shortcut.  

Might it make sense to have only a single setting, but place it both on the view menu and within the Configure KMM dialog?  The View could just be "Show all accounts." but in the configure dialog the wording could be longer (such as "Show all accounts.  Without this set, closed accounts will not be displayed in the Accounts View or on the Home Page.")
Comment 7 Martin Steigerwald 2019-07-24 07:54:35 UTC
(In reply to Jack from comment #6)
> I actually do use it fairly often.  I have many old accounts of various

I see.

> Might it make sense to have only a single setting, but place it both on the
> view menu and within the Configure KMM dialog?  The View could just be "Show
> all accounts." but in the configure dialog the wording could be longer (such
> as "Show all accounts.  Without this set, closed accounts will not be
> displayed in the Accounts View or on the Home Page.")

Works for me. I just wonder which additional accounts disabling "Show all accounts" would not show.
Comment 8 Ian Neal 2019-07-24 08:59:11 UTC
(In reply to Jack from comment #6)
> I actually do use it fairly often.  I have many old accounts of various
> sorts closed.  Unfortunately, I seem to need to modify transactions in those
> accounts on occasion, and have to reopen the account to edit the transaction
> and then close the account.  If closed accounts are not shown, I need to
> toggle the display, make my edit, and then toggle again.
Same here, I find it very convenient to be able to toggle it in the view menu.

> So, I agree with having only a single place to control this, but we should
> think carefully about the wording.  Here I am less concerned with new users
> than with existing users who need to toggle the view, and only remember one
> or the other of the old settings, but not both.  We should also definitely
> retain a keyboard shortcut.  
When I first read this, until I read your third paragraph, I thought you meant once place in the UI not one setting in the background.

> Might it make sense to have only a single setting, but place it both on the
> view menu and within the Configure KMM dialog?  The View could just be "Show
> all accounts." but in the configure dialog the wording could be longer (such
> as "Show all accounts.  Without this set, closed accounts will not be
> displayed in the Accounts View or on the Home Page.")
Is it possible to leave the current wording just change the background setting and reverse the logic, or would that be too confusing?
Comment 9 Mike Jenck 2020-06-06 03:11:20 UTC
I was trying to get the Show All Accounts to hide closed one - it would do it.

https://youtu.be/fhhwacivOKs

Once I went Settings / General / Filter I set "do not show closed accounts" it now works as expected.

If the "do not show closed accounts" is unchecked then the flag doe nothing.
Comment 10 Paul Worrall 2020-12-29 09:31:53 UTC
There is also "Hide unused categories" on the View menu and "Do not show unused categories" in the KMM settings. Should they also be combined?
Comment 11 Thomas Baumgart 2024-07-14 13:49:48 UTC
Git commit a648efbe170485aeef37a6d3a54d4f40963a7691 by Thomas Baumgart.
Committed on 14/07/2024 at 13:49.
Pushed by tbaumgart into branch 'master'.

Keep global settings in sync with view menu entries
FIXED-IN: 5.2

M  +3    -2    kmymoney/kmymoney.cpp

https://invent.kde.org/office/kmymoney/-/commit/a648efbe170485aeef37a6d3a54d4f40963a7691