Bug 409957 - Adjust the size of kickoff settings window to unhide the tip on bottom
Summary: Adjust the size of kickoff settings window to unhide the tip on bottom
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.16.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-18 14:39 UTC by Patrick Silva
Modified: 2019-09-26 20:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.0


Attachments
screenshot (61.93 KB, image/png)
2019-07-18 14:39 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-07-18 14:39:27 UTC
Created attachment 121612 [details]
screenshot

SUMMARY
As we can see in the attached screenshot, currently "Drag tabs between the boxes..."
on bottom is hidden when you open kickoff settings.


STEPS TO REPRODUCE
1.  open kickoff settings
2. 
3. 

EXPECTED RESULT
The tip on bottom is always visible when you open kickoff settings.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.16.3
KDE Frameworks Version: 5.60.0
Qt Version: 5.13.0
Comment 1 Nate Graham 2019-08-14 17:33:54 UTC
Submitted a patch: https://phabricator.kde.org/D23158
Comment 2 Nate Graham 2019-09-26 20:18:56 UTC
Git commit 184f2a8274dc38786a0ca3cb22f49e1a2d688aae by Nate Graham.
Committed on 26/09/2019 at 20:18.
Pushed by ngraham into branch 'Plasma/5.17'.

[applets/kickoff] Improve appearance of draggable button grid in settings window

Summary:
The button grid was not centered, the content inside the buttons was not centered, the
vertical spacing was too high on top and too low on bottom, and the explanatory text
got cut off.

This patch solves all those problems.

Big thanks to @davidedmundson for his help getting this merge-ready.
FIXED-IN: 5.17.0

Test Plan:
Before: {F7247447, size=full}
After: {F7247446, size=full}

Reviewers: #vdg, #plasma, davidedmundson, GB_2, hein

Reviewed By: #vdg, #plasma, davidedmundson, GB_2

Subscribers: hein, GB_2, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23158

M  +13   -10   applets/kickoff/package/contents/ui/ConfigButtons.qml
M  +5    -6    applets/kickoff/package/contents/ui/ConfigGeneral.qml
M  +20   -19   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

https://commits.kde.org/plasma-desktop/184f2a8274dc38786a0ca3cb22f49e1a2d688aae