Bug 409954 - KIO FTP: kioclient hangs while copying file over existing file [copy() did not call finished() or error()]
Summary: KIO FTP: kioclient hangs while copying file over existing file [copy() did no...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: FTP (show other bugs)
Version: 5.60.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
: 410357 411819 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-07-18 13:12 UTC by Yaroslav Sidlovsky
Modified: 2019-09-12 15:24 UTC (History)
8 users (show)

See Also:
Latest Commit: https://commits.kde.org/kio/ccae728a5494658d865705628bb6e89ead4dd54e
Version Fixed In: 5.62

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Yaroslav Sidlovsky 2019-07-18 13:12:07 UTC 
How to reproduce:

1. Copy file to some dir:
kioclient5 cp f30.png ftp://127.0.0.1/Public 

2. Copy same file to the same dir:
kioclient5 cp f30.png ftp://127.0.0.1/Public 

After step 2 kioclient will hang indefinitely,
it'll also produce this warning: "kf5.kio.core: copy() did not call finished() or error()! Please fix the "kio_ftp" KIO slave"

 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Yaroslav Sidlovsky 2019-07-18 13:12:47 UTC 
Proposed fix: https://phabricator.kde.org/D22528
Comment 2 Anton K 2019-07-18 15:07:14 UTC 
I also have this problem in the Dolphin.

OS: KDE neon 5.16
DE: KDE 5.60.0 / Plasma 5.16.3
Qt: 5.12.3
Kernel: x86_64 Linux 5.0.0-050000-generic
Comment 3 Driglu4it 2019-07-24 06:01:45 UTC 
Confirm this bug
Comment 4 Yaroslav Sidlovsky 2019-08-02 13:44:49 UTC 
Bug still present in plasma 5.16.4.
Comment 5 Yaroslav Sidlovsky 2019-08-12 09:42:15 UTC 
Duplicate of: https://bugs.kde.org/show_bug.cgi?id=410357.
Comment 6 Nate Graham 2019-08-12 13:56:11 UTC 
*** Bug 410357 has been marked as a duplicate of this bug. ***
Comment 7 Simone 2019-08-12 18:23:30 UTC 
Can confirm. The dialogs either do not show or show after a long delay, but the FTP connections stay alive and have to be manually closed.
Comment 8 Harald Sitter 2019-08-22 13:09:19 UTC 
Git commit ccae728a5494658d865705628bb6e89ead4dd54e by Harald Sitter, on behalf of Yaroslav Sidlovsky.
Committed on 22/08/2019 at 13:09.
Pushed by sitter into branch 'master'.

KIO FTP: Fix file copy hanging when copying to existing file

Summary: BUG: 409954

Test Plan:
Before patch:
1. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png
2. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png
Kioclient will hang with debug message: `kf5.kio.core: copy() did not call finished() or error()! Please fix the "kio_ftp" KIO slave`

After patch:
1. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png
2. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png
All is OK, kioclient5 will exit with error status and say that file already exists.

Reviewers: sitter, dfaure, cfeck

Reviewed By: sitter

Subscribers: ngraham, rikmills, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22528

M  +4    -6    src/ioslaves/ftp/ftp.cpp

https://commits.kde.org/kio/ccae728a5494658d865705628bb6e89ead4dd54e
Comment 9 Nate Graham 2019-09-12 15:24:07 UTC 
*** Bug 411819 has been marked as a duplicate of this bug. ***