Bug 409914 - Circular *refresh* and update-* icons have arrows that are facing in the wrong direction
Summary: Circular *refresh* and update-* icons have arrows that are facing in the wron...
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Nate Graham
Depends on:
Reported: 2019-07-17 19:37 UTC by Thiago Sueto
Modified: 2019-07-23 09:26 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.61


Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Sueto 2019-07-17 19:37:28 UTC
I know this is very minor and most users wouldn't notice it, but...
The breeze icon for updates and the "Up to date" image on discover is a circle containing counter-clockwise arrows, yet the "Fetching updates..." animation on discover rotates clockwise.

I'm on Kubuntu 19.04 with backports enabled.
Comment 1 Nate Graham 2019-07-17 20:34:15 UTC
the update* icons also have the arrows going counter-clockwise, so I guess we should just have the spinner go that way too. Moving to qqc2-desktop-style which is where the animation styling lives.
Comment 2 Kai Uwe Broulik 2019-07-18 07:43:55 UTC
I wouldn't change the direction. Plasma's busy indicator also turns clockwise. Instead, the icon should be changed.
Comment 3 2wxsy58236r3 2019-07-18 12:37:15 UTC
I agree that the icons should be changed. Both Apple (macOS) Software Update and Mozilla Firefox Updater uses icons with clockwise arrows.
Comment 4 Nate Graham 2019-07-18 15:31:45 UTC
Yeah ok, that makes sense. Moving to Breeze icons.
Comment 5 Nate Graham 2019-07-18 18:48:53 UTC
Patch: https://phabricator.kde.org/D22534
Comment 6 Nate Graham 2019-07-18 19:12:41 UTC
Git commit 74c4155ff3d703e299a3d86e7d3d030d2c6151e1 by Nate Graham.
Committed on 18/07/2019 at 19:12.
Pushed by ngraham into branch 'master'.

Use clockwise arrows for *refresh* and update-* icons

Right now we are inconsistent with the arrow directionality for our circular icons:
some use clockwise arrows, and some use counterclockwise.

This patch standardizes everything on the clockwise direction. This not only makes
everything nice and consistent, but it also fixes the busy indictor spinner looking
weird (it rotates clockwise, like all opther busy spinners we've ever seen in any UI
FIXED-IN: 5.61

Test Plan:







The eagle-eyed reviewer will note that the different icons also have different styles of arrows and their rotational offset is also different, but if that's a pre-existing issue that can be done in another patch, if it's also something we want to unify.

Reviewers: #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22534

M  +6    -11   icons-dark/actions/16/view-refresh.svg
M  +6    -15   icons-dark/actions/22/view-refresh.svg
M  +6    -11   icons-dark/actions/24/view-refresh.svg
M  +6    -11   icons-dark/actions/32/view-refresh.svg
M  +42   -1    icons-dark/preferences/32/yast-update.svg
M  +7    -16   icons-dark/status/22/update-high.svg
M  +7    -21   icons-dark/status/22/update-low.svg
M  +7    -22   icons-dark/status/22/update-medium.svg
M  +6    -11   icons-dark/status/22/update-none.svg
M  +6    -11   icons/actions/16/view-refresh.svg
M  +6    -15   icons/actions/22/view-refresh.svg
M  +6    -11   icons/actions/24/view-refresh.svg
M  +6    -11   icons/actions/32/view-refresh.svg
M  +42   -1    icons/preferences/32/yast-update.svg
M  +7    -16   icons/status/22/update-high.svg
M  +7    -21   icons/status/22/update-low.svg
M  +7    -22   icons/status/22/update-medium.svg
M  +6    -11   icons/status/22/update-none.svg

Comment 7 Nate Graham 2019-07-19 02:40:49 UTC
Git commit 4e35b61a83fb5a08c8350713dbdc3461003e600e by Nate Graham.
Committed on 19/07/2019 at 02:40.
Pushed by ngraham into branch 'master'.

Update refresh and restart icons to reflect new breeze-icons versions

Like D22534, but for the Plasma theme.

Reviewers: #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22541

M  +32   -36   src/desktoptheme/breeze/icons/system.svg
M  +21   -81   src/desktoptheme/breeze/icons/view.svg

Comment 8 victorhck 2019-07-23 08:49:31 UTC
This also fix the wrong direction icon in Kickoff menu and log out screen? (the arrows in that points to left).
Comment 9 Kai Uwe Broulik 2019-07-23 09:26:15 UTC