Bug 409888 - Input field text widget do not respect anti-aliasing preferences
Summary: Input field text widget do not respect anti-aliasing preferences
Status: RESOLVED FIXED
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.59.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-17 09:42 UTC by Martin van Es
Modified: 2019-07-18 20:22 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.61


Attachments
Font preferences dialog showing 2 input fields anti-aliased that should be hinted without anti-aliasing (12.85 KB, image/png)
2019-07-17 09:42 UTC, Martin van Es
Details
Launcher search box (4.39 KB, image/png)
2019-07-17 12:42 UTC, Martin van Es
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin van Es 2019-07-17 09:42:03 UTC
Created attachment 121576 [details]
Font preferences dialog showing 2 input fields anti-aliased that should be hinted without anti-aliasing

SUMMARY
Some input field text widgets show text anti-aliased for sizes that should be excluded according to the preferences which can ironically be seen in the attachment of the fonts preferences dialog.

STEPS TO REPRODUCE
1. Exclude 6pt to 14pt fonts from anti-aliasing
2. Set General font to 9pt (within excluded range)
3. Find input text widget, e.g. on fonts preferences dialog for anti-alias exclude ranges

OBSERVED RESULT
Input field text is rendered with anti-aliasing

EXPECTED RESULT
Input field text rendered hinted without anti-aliasing

SOFTWARE/OS VERSIONS
Operating System: Kubuntu 19.04
KDE Plasma Version: 5.16.3
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.2
Kernel Version: 5.2.1
OS Type: 64-bit
Processors: 4 × Intel® Core™ i7-7500U CPU @ 2.70GHz
Memory: 15.5 GiB of RAM
Comment 1 Kai Uwe Broulik 2019-07-17 10:02:34 UTC
You mean the spinboxes?
Comment 2 Kai Uwe Broulik 2019-07-17 10:16:54 UTC
Patch https://phabricator.kde.org/D22505
Comment 3 Martin van Es 2019-07-17 11:52:56 UTC
It's not only the spinboxes, the application launcher searchbox has the same issue, but maybe your patch covers it all?
Comment 4 Kai Uwe Broulik 2019-07-17 12:37:37 UTC
There's a comment in the code explaining why it does that:

    /*
     * Since the password echo is a circle without vertical or horizontal lines, it won't be
     * more blurred with different rendring types.
     * Using Qt rendering, the dots will look more aligned and equally spaced.
     * Also if we are on mobile, make sure we use QtRendering
     * Finally, use QtRendering if we're using a non-integer scale factor to work around
     * https://bugreports.qt.io/browse/QTBUG-67007
     *
     * color with an alpha is also broken. https://bugreports.qt.io/browse/QTBUG-70138
     *
     * Given we have so many issues, just enable QtRendering for now
     */
Comment 5 Martin van Es 2019-07-17 12:42:50 UTC
Created attachment 121582 [details]
Launcher search box

The launcher searchbox is not a password echo, but I leave it up to the experts to decide if that can be fixed or not...
Comment 6 Kai Uwe Broulik 2019-07-18 15:02:24 UTC
Git commit 8927e90ac08f65de8e15f066200bb7252b86ec1a by Kai Uwe Broulik.
Committed on 18/07/2019 at 15:01.
Pushed by broulik into branch 'master'.

[SpinBox] Set renderType

Ensures it uses the system's font rendering settings

Differential Revision: https://phabricator.kde.org/D22505

M  +5    -0    org.kde.desktop/SpinBox.qml

https://commits.kde.org/qqc2-desktop-style/8927e90ac08f65de8e15f066200bb7252b86ec1a