Bug 409839 - Google Photos import does not download videos correctly
Summary: Google Photos import does not download videos correctly
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Google (other bugs)
Version First Reported In: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR major
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-15 22:13 UTC by Adam S
Modified: 2019-07-16 17:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.2.0
Sentry Crash Report:


Attachments
An example of a downloaded video file. (207.91 KB, video/mp4)
2019-07-15 22:13 UTC, Adam S
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam S 2019-07-15 22:13:05 UTC
Created attachment 121536 [details]
An example of a downloaded video file.

SUMMARY
Google Photos import does not download videos correctly, instead downloading still images as videos.

STEPS TO REPRODUCE
1. Select an album to download, containing video files.
2. Attempt to play a downloaded video file.

OBSERVED RESULT
A ten-second long video clip is downloaded, containing an mjpeg-encoded frame from the chosen video.

EXPECTED RESULT
The video clip should be downloaded in its entirety, along with all accompanying metadata.

SOFTWARE/OS VERSIONS
Windows: 10.0.18362.239

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2019-07-16 04:02:28 UTC
which digiKam version do you use exactly ?
Comment 2 Maik Qualmann 2019-07-16 05:55:14 UTC
Confirmed, the import tool saved a image from the video. I will fix it.

Maik
Comment 3 Maik Qualmann 2019-07-16 16:36:22 UTC
Git commit 62fb67cf789794de8ebc9f3d5f460e66e0f3a4ee by Maik Qualmann.
Committed on 16/07/2019 at 16:35.
Pushed by mqualmann into branch 'master'.

use the file name from the header for the import

M  +12   -1    core/dplugins/generic/webservices/google/gphoto/gptalker.cpp
M  +1    -1    core/dplugins/generic/webservices/google/gphoto/gptalker.h
M  +14   -5    core/dplugins/generic/webservices/google/gswindow.cpp
M  +5    -4    core/dplugins/generic/webservices/google/gswindow.h

https://invent.kde.org/kde/digikam/commit/62fb67cf789794de8ebc9f3d5f460e66e0f3a4ee
Comment 4 Maik Qualmann 2019-07-16 17:51:28 UTC
Git commit 9ed5427eca0b701466b204b1e4023d4f56672a09 by Maik Qualmann.
Committed on 16/07/2019 at 17:49.
Pushed by mqualmann into branch 'master'.

fix download parameter and add redirection support
FIXED-IN: 6.2.0

M  +2    -1    NEWS
M  +36   -12   core/dplugins/generic/webservices/google/gphoto/gptalker.cpp

https://invent.kde.org/kde/digikam/commit/9ed5427eca0b701466b204b1e4023d4f56672a09