Bug 409811 - Add "About System" page into Settings app
Summary: Add "About System" page into Settings app
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2019-07-15 06:58 UTC by Matej Mrenica
Modified: 2019-08-01 20:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.0


Attachments
Patch (1.20 KB, patch)
2019-07-16 19:29 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2019-07-15 06:58:32 UTC
SUMMARY
I think It would make sense to have a page about system configuration in KDE System Settings app. Just like the first page in Kinfocenter or it even could be the same page.
Comment 1 Nate Graham 2019-07-16 15:14:25 UTC
Not a bad idea. System Settings is way more discoverable than KInfoCenter, and I think it makes sense to add that page there. It was ehere I first looked for this info myself when I was a new Plasma user. The page could even have a button that says, "Show More Information" that launches the full KInfoCenter.
Comment 2 Nate Graham 2019-07-16 19:29:14 UTC
Created attachment 121561 [details]
Patch

If we want to do this, there are a few ways:
- Add toolbar button/menu item (depending on the view) that opens the about-distro KCM when clicked
- Have KInfoCenter install a .desktop file (patch attached) that makes the about_distro KCM appear in the list of KCMs in System Settings.

I didn't submit the patch, as we may not actually want to do it this way (or at all).
Comment 3 Matej Mrenica 2019-07-17 09:20:26 UTC
(In reply to Nate Graham from comment #2)
> Created attachment 121561 [details]
> Patch
> 
> If we want to do this, there are a few ways:
> - Add toolbar button/menu item (depending on the view) that opens the
> about-distro KCM when clicked
> - Have KInfoCenter install a .desktop file (patch attached) that makes the
> about_distro KCM appear in the list of KCMs in System Settings.
> 
> I didn't submit the patch, as we may not actually want to do it this way (or
> at all).

Option #2 sounds reasonable, If you submitted it as a patch there could at least be a discussion about it.
Comment 4 Nate Graham 2019-07-24 20:41:56 UTC
Sure, will do. In fact it's as simple as a one-liner, not my clumsy first attempt that I attached earlier.
Comment 5 Nate Graham 2019-07-24 21:47:57 UTC
Decided to implement it in a slightly different way. Here's a patch: https://phabricator.kde.org/D22728
Comment 6 Nate Graham 2019-08-01 20:57:17 UTC
Git commit 09598972736b5896346aabe51f973b3f811a4882 by Nate Graham.
Committed on 01/08/2019 at 20:57.
Pushed by ngraham into branch 'master'.

Show about distro KCM in System Settings' System Administration category

Summary:
This is an alternative to D22728. It makes the {nav System Information} KCM appear in
System Settings' {nav System Administration} section.

Advantages over D22728:
- The information is more discoverable
- It automatically disappears if KInfoCenter is not installed or removed
- It requires no changes to SystemSettings' fragile codebase

Disadvantages:
- Since it doesn't open KInfoCenter or have a link to it, all the other information in KInfoCenter is not exposed
- If we do later want to adjust this KCM to have a button to open KInfoCenter when pushed, we'll hit https://bugs.kde.org/show_bug.cgi?id=410169 since the KCM will be already open in System Settings
FIXED-IN: 5.17.0

Test Plan: {F7096717}

Reviewers: #vdg, #plasma, filipf, GB_2

Reviewed By: #vdg, filipf, GB_2

Subscribers: mthw, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22742

M  +1    -0    Modules/about-distro/src/about-distro.desktop

https://commits.kde.org/kinfocenter/09598972736b5896346aabe51f973b3f811a4882