Bug 409774 - Don't show "Network disconnected" notification after the disconnect button in the plasma-nm widget is clicked
Summary: Don't show "Network disconnected" notification after the disconnect button in...
Status: CONFIRMED
Alias: None
Product: plasma-nm
Classification: Plasma
Component: applet (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Jan Grulich
URL:
Keywords:
: 421369 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-07-13 17:18 UTC by Nate Graham
Modified: 2020-11-19 22:50 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-07-13 17:18:10 UTC
In general, it never makes sense to show a notification in response to a successful direct user action. The user expects that their action is completed successfully; there's no reason to say "the thing you did worked!"

Applying this principle to plasma-nm, there's no reason to show a "Network disconnected" notification when the user clicks on the "Disconnect" button in the plasma-nm network list. This notification should only appear in response to a disconnection that was not initiated by the user.
Comment 1 fire f. 2019-08-09 07:12:02 UTC
always found that unnerving too, but luckily one can switch it off with 3 clicks. Cluttering the desktop with somewhat pointless notifications is being frowned upon.
Comment 2 fire f. 2019-08-09 07:13:00 UTC
at least we have a "do not disturb" mode by now, which I make use of heavily!
Comment 3 Raphaël Jakse 2019-10-16 08:11:41 UTC
An additional element to assess this bug: a problem I found with this behavior is that at times, the notifications prevent the user from using plasma-nm to connect to another network until the user closes them, because they cover the widget.
Comment 4 Nate Graham 2019-10-16 13:59:30 UTC
That's fixed in Plasma 5.17.
Comment 5 Patrick Silva 2019-10-16 14:16:39 UTC
"Network disconnected" notification only appears after plasma-nm popup to be closed.

Operating System: Arch Linux 
KDE Plasma Version: 5.17.0
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Comment 6 Nate Graham 2020-06-11 05:02:03 UTC
*** Bug 421369 has been marked as a duplicate of this bug. ***
Comment 7 Justin Zobel 2020-11-19 22:43:51 UTC
This is quite silly, I'm sure you could fix it when you get a moment Nate ;)
Comment 8 Nate Graham 2020-11-19 22:45:14 UTC
Believe it or not, I have looked into it, and it's not as easy as it seems, because you need to disambiguate the sources of the disconnection (happened naturally vs user-initiated) and the code isn't set up for this right now. It needs some refactoring to support it.
Comment 9 Raphaël Jakse 2020-11-19 22:50:29 UTC
Sadly, I fully believe this.

I don't know why, and this might be due to the recent improvements related to the notifications, this has been less an issue for me.

Ah, yes, obviously after rereading my comment from last year: the notifications do not cover the network widget anymore!