Created attachment 121439 [details] patch against git VALGRIND_3_14_0-225-g514f89938 In my work dhat is almost useful, since the most important thing isn't which byte of a struct is accessed, but in which way (read/write), to avoid things like false sharing. Therefore we have always been using a modification of exp-dhat, and now that we have upgraded to the overhauled version of valgrind/dhat we had to adapt to the new kind of output and I would like to share our patch (we also made the output a little bit nicer formatted, but didn't really bother to integrate it into the drop down filter). Hopefully you can integrate some or all of this into dhat to make it even more useful.
The attached patch is in an unusual format, e.g. contains various control characters. Also, what is the idea that the patch is implementing ? Seems there is no doc changed, no test changed. So, that makes it not easy to see what you propose to add.
Created attachment 121461 [details] patch against git VALGRIND_3_14_0-225-g514f89938
(In reply to Philippe Waroquiers from comment #1) > The attached patch is in an unusual format, e.g. contains various control > characters. whoops, my fault, I wasn't aware of that the "git diff" colour output is also present when redirecting to a file, did it explicitly without. > > Also, what is the idea that the patch is implementing ? As I said it not only tells which byte was accessed, but also in what way (read/write) > > Seems there is no doc changed, no test changed. I wasn't aware of that its necessary to do all this, you can then close this ticket, I was just sharing our changes in the hope it might be useful for other people that want to know the same information. > > So, that makes it not easy to see what you propose to add.
(In reply to plasmahh from comment #3) > > Seems there is no doc changed, no test changed. > I wasn't aware of that its necessary to do all this, you can then close this > ticket, I was just sharing our changes in the hope it might be useful for > other people that want to know the same information. Yes, of course, any contribution is welcome. A change has however more chances to be integrated if it is clear what it does, and the more complete the patch is, e.g. with doc updated, with a test, ...
FWIW, you can run some tests of DHAT's viewer by loading dhat with `?test=1` appended to the URL.