Bug 409546 - collapse-all icons don’t respect color schemes
Summary: collapse-all icons don’t respect color schemes
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.16.0
Platform: unspecified Unspecified
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-06 08:30 UTC by David Hurka
Modified: 2019-07-07 12:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.61


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Hurka 2019-07-06 08:30:17 UTC
SUMMARY
These icons (breeze and breeze-dark, all sizes) don’t have the
id="current-color-scheme"
attribute in the style element.

Result is, that these icons are nealy invisible in dark color themes, because they don’t respect the foreground color.

Screenshot from Okular: https://phabricator.kde.org/F6848602
Comment 1 Nate Graham 2019-07-07 12:26:17 UTC
Git commit 8ec6b1ba567029067e458525048477a489b042c3 by Nate Graham, on behalf of Natsumi Higa.
Committed on 07/07/2019 at 12:26.
Pushed by ngraham into branch 'master'.

Add id="current-color-scheme" to collapse-all icons

Summary:
`collapse-all` icons have no `id="current-color-scheme"` attribute in the `<style>` element, so they do not respect the foreground color and these icons are hardly visible in dark color themes.

Special thanks: David Hurka, who reported the bug and suggested the change

Usage in Okular, Before:
{F6848602}
After:
{F6980718}

Reviewers: #vdg, davidhurka, ndavis

Reviewed By: #vdg, davidhurka, ndavis

Subscribers: ndavis, davidhurka, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22297

M  +9    -2    icons-dark/actions/16/collapse-all.svg
M  +9    -2    icons-dark/actions/22/collapse-all.svg
M  +9    -2    icons-dark/actions/24/collapse-all.svg
M  +9    -2    icons-dark/actions/32/collapse-all.svg
M  +9    -2    icons/actions/16/collapse-all.svg
M  +9    -2    icons/actions/22/collapse-all.svg
M  +9    -2    icons/actions/24/collapse-all.svg
M  +9    -2    icons/actions/32/collapse-all.svg

https://commits.kde.org/breeze-icons/8ec6b1ba567029067e458525048477a489b042c3