Bug 409541 - Sort by toolbar icon not changing properly
Summary: Sort by toolbar icon not changing properly
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 19.04.2
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-06 00:16 UTC by Gabriel Fernandes
Modified: 2024-05-28 08:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Zip file containing 3 screenshots about the problem (235.61 KB, application/zip)
2019-07-06 00:16 UTC, Gabriel Fernandes
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Fernandes 2019-07-06 00:16:48 UTC
Created attachment 121346 [details]
Zip file containing 3 screenshots about the problem

SUMMARY
When you set icons to individual sorting types, like an icon to sort by name, another to sort by size, you can do this by changing the icon of the "name" toolbar for example, the sort by toolbar icon gets changed when you use that sorting type, if you use sort by size and you have set an icon to the "size" toolbar the sort by toolbar icon gets the same icon, pretty neat, you can know which sort mode you are on.
The problem is when you sort by another thing that doesn't have icon the last icon used keeps, for example you were sorting by size (and it has a different icon) and after it you change the sorting type to sort by Rating, the icon to sort by size doesn't change, you may think you are still sorting by size. Which makes me think it's a bug is when you close Dolphin and open it again it shows the default icon of Sort By if the sorting type doesn't have icon, which could happen immediately when you change to a sorting that doesn't have an icon. Changing between sorting types that has icons works great, the icons are changed immediately.

STEPS TO REPRODUCE
1. Add Sort By toolbar
2. Add some sorting types toolbar to change its icons ("name", "size", "modified")
3. Change the sorting type between the ones you changed the icon (the Sort By toolbar icon will change to it too)
4. Change to a sort that doesn't have an icon, the last icon will stay (instead of going back to default Sort By icon)
5. If you close and reopen Dolphin if the last sorting didn't have icon the default will get used (could have happened without needing to restart the application)

OBSERVED RESULT
When changing the sort type to one that does't have a different icon, the last icon of Sort By toolbar doesn't get back to the default icon.

EXPECTED RESULT
When changing the sort type to one that does't have a different icon the Sort By icon come back to the original one.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.16
KDE Plasma Version: 5.16.2
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.3
Kernel Version: 4.18.0-25-generic

ADDITIONAL INFORMATION
Images as attachment to better demonstrate the issue
Comment 1 Gabriel Fernandes 2019-07-06 15:42:12 UTC
It also affects right click context menu, window main menu and when main menu not shown control menu, it's not a toolbar restricted problem.
Comment 2 Nate Graham 2019-07-15 21:33:45 UTC
Are you modifying the source code to produce these changes?
Comment 3 Gabriel Fernandes 2019-07-15 22:17:07 UTC
No, I'm not, I'm changing the icons in configure toolbars window, Change icon button. This way you can change icons for specific toolbars, like the ones I've changed (name, modified, size).
Comment 4 Nate Graham 2019-07-16 19:32:17 UTC
Thanks.

This seems like something we should really support natively, rather than requiring the user to hack it into place manually. I especially like your use of Alt shortcuts for quickly switching between sort orders.
Comment 5 Gabriel Fernandes 2019-08-24 20:25:58 UTC
Should I upload a video showing how to reproduce this one? As the status of the report is still reported.
It's perfectly reproducible in Dolphin 19.08
Comment 6 Nate Graham 2019-08-24 20:39:46 UTC
It wouldn't hurt. :)
Comment 7 Gabriel Fernandes 2019-08-24 23:40:14 UTC
here you go https://youtu.be/qEVkCX248NE
Comment 8 Nate Graham 2019-08-25 00:00:44 UTC
Very interesting, thanks.