Bug 409526 - Dolphin 19.04.2 Configure Shortcuts shows duplicate entries
Summary: Dolphin 19.04.2 Configure Shortcuts shows duplicate entries
Status: CONFIRMED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 19.04.2
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-05 12:22 UTC by chimak111
Modified: 2019-10-27 11:10 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Image of the Configure Shortcuts window show duplicate entries for Accessed and for Comment (77.11 KB, image/png)
2019-07-05 12:22 UTC, chimak111
Details
Gwenview shortcuts separated into categories (28.11 KB, image/png)
2019-10-27 11:10 UTC, Alex
Details

Note You need to log in before you can comment on or make changes to this bug.
Description chimak111 2019-07-05 12:22:08 UTC
Created attachment 121335 [details]
Image of the Configure Shortcuts window show duplicate entries for Accessed and for Comment

SUMMARY
Open Configure Shortcuts. Several shortcuts are apparently duplicated.

STEPS TO REPRODUCE
1. Open Dolphin
2. Click on Control > Configure Shortcuts
3. 

OBSERVED RESULT
Some entries appear twice.

EXPECTED RESULT
Entries should appear only once.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: KDE neon 5.16
(available in About System)
KDE Plasma Version: 5.16.2
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION

Dolphin 19.04.2 shows the following duplicate entries in the Configure Shortcuts window:
Accessed
Comment
Created
Modified
Rating
Size
Tags
Type
Comment 1 Julian Steinmann 2019-07-05 16:10:45 UTC
I can confirm this behavior with Dolphin 19.04.2.
Comment 2 2wxsy58236r3 2019-07-06 03:16:41 UTC
Please have a look at src/views/dolphinviewactionhandler.cpp.

I guess the entries should be labeled as "Sort XXX ascending" and "Sort XXX descending" (XXX = Accessed, Comment, Created, etc.), not just "XXX".
Comment 3 Alex 2019-10-27 11:09:03 UTC
One of each of these shortcuts is for sorting and the other one is for showing additional information besides just the filename.

Directly changing the text property of these actions is not a good idea because that would be too verbose in menus. Sort By > Sort by X would make no sense.

I can't find a way to only change the text displayed when configuring shortcuts but not in regular menus. Another solution would be to reduce ambiguity by separating actions into categories. See the attachment below, this is what Gwenview does. It would also help reduce ambiguity with other shortcuts and make finding them easier.
Comment 4 Alex 2019-10-27 11:10:33 UTC
Created attachment 123512 [details]
Gwenview shortcuts separated into categories