Bug 409443 - Changing time shouldn't mark the document as modified
Summary: Changing time shouldn't mark the document as modified
Status: RESOLVED NOT A BUG
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Emmet O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-03 08:01 UTC by Tiar
Modified: 2021-01-26 00:30 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tiar 2019-07-03 08:01:18 UTC 
SUMMARY
When you're working on animation, changing the time is rather common. For example one may want to open the animation file, check if frames are alright, and tehn render it - without making any changes except for changing the time.



STEPS TO REPRODUCE
1. Open animation file.
2. Change the time.


OBSERVED RESULT
The document is marked as modified.

EXPECTED RESULT
The document should not be marked as modified. The change of time could be visible in the Undo Stack, why not, but I don't see a reason to actually kick autosave or bother the user to save the file on closing f the only thing they did was changing the time.


SOFTWARE/OS VERSIONS
Windows: 10
Qt Version: 5.12.2
Krita version: git edb2c8414b
Comment 1 vanyossi 2019-07-03 15:16:03 UTC 
On the other hand, Do you think changing start and end frame should trigger "document modified" state?

And yes, scrubbing trought the timeline should not set the document as modified. But we open the document on the frame it was last saved, also the preview also renderes from that current frame.
Comment 2 wolthera 2019-09-21 15:35:14 UTC 
If two developers agree on a bug, then it is confirmed.
Comment 3 Emmet O'Neill 2021-01-26 00:30:29 UTC 
I'm not really sure this one is worth changing. 

As Ivan mentioned the current time is part of the document's state. We save, load it, and keep track of its undo history. Because of that, changes to the time are recognized as being significant, and we would have to create an special exception just for time switching.