Bug 409430 - Okular keeps warning me about open tabs when I want to close the application/window
Summary: Okular keeps warning me about open tabs when I want to close the application/...
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.6.2
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-02 18:52 UTC by jan
Modified: 2019-07-02 22:18 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
ScreenshotOfWarningPopupForOpenTabs (19.10 KB, image/png)
2019-07-02 18:52 UTC, jan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jan 2019-07-02 18:52:16 UTC
Created attachment 121293 [details]
ScreenshotOfWarningPopupForOpenTabs

SUMMARY

Okular doesn't store my checked preferences that I don't want to get warned about the closing off several open tabs at once...
It keeps popping up again everytime I'm in the same situation even though I've unchecked it before.

STEPS TO REPRODUCE
1. Open several (pdf) documents in okular in tabs.
2. Try to close okular
3. unmark the checkbox to not warn you again next time.
4. finally close okular.
5. open okular again and repeat all steps.

OBSERVED RESULT

Warning about open tabs keeps popping up everytime one would like to close okular no matter if the checkbox has been unmarked or not.

EXPECTED RESULT

No more warnings the next time I'm trying to close okular.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Fedora 30
(available in About System)
KDE Plasma Version: can't find it within okular. I'm on gnome 3.32.2
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.1

ADDITIONAL INFORMATION

Okular also uses the xcb windowing system

I'm using Gnome 3.32.2 as DE.
Comment 1 Albert Astals Cid 2019-07-02 22:18:25 UTC
Git commit cf7d847a331c20f1b58bb4b58a6147023902ec55 by Albert Astals Cid.
Committed on 02/07/2019 at 22:18.
Pushed by aacid into branch 'Applications/19.04'.

Fix saving "don't show again" when not using frameworksintegration

When not using frameworks integration we only get "false" in
shouldBeShownYesNo when the saved value is yes/no so set it to yes.

Also it was a bit weird before because we were using an uninitialized
value, so this is much better :)

M  +1    -1    shell/shell.cpp

https://invent.kde.org/kde/okular/commit/cf7d847a331c20f1b58bb4b58a6147023902ec55