Bug 409213 - Prefer the saved auth token to login over a password
Summary: Prefer the saved auth token to login over a password
Status: RESOLVED FIXED
Alias: None
Product: Ruqola
Classification: Applications
Component: backend (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Laurent Montel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-26 14:58 UTC by Christian Dywan
Modified: 2019-06-28 12:03 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/ruqola/a3f0e539cc41e5f559353ea6fc9a5edd60bb7a3e
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2019-06-26 14:58:17 UTC 
This is especially noticeable in connection with 2FA-enabled accounts (bug 409212). As the password is currently checked first, existing tokens are effectively ignored and login happens from scratch every time Ruqola is started.
Comment 1 Christian Dywan 2019-06-26 15:06:03 UTC 
https://phabricator.kde.org/differential/diff/60695/
Comment 2 Laurent Montel 2019-06-27 04:50:53 UTC 
Hi,
could you use https://phabricator.kde.org/ + arc (https://community.kde.org/Infrastructure/Phabricator). So we can speak about your patch.
Thanks.
Comment 3 Laurent Montel 2019-06-28 12:03:20 UTC 
Git commit a3f0e539cc41e5f559353ea6fc9a5edd60bb7a3e by Laurent Montel.
Committed on 28/06/2019 at 12:01.
Pushed by mlaurent into branch 'arcpatch-D22112'.

Patch from Christian Dywan

Prefer logging in via the saved auth token

Summary:
This in particular avoids re-authenticating with a 2FA code every time Ruqola is opened (see bug 409212).

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: mlaurent

Differential Revision: https://phabricator.kde.org/D22112

M  +6    -6    src/ruqolacore/ddpapi/ddpclient.cpp

https://commits.kde.org/ruqola/a3f0e539cc41e5f559353ea6fc9a5edd60bb7a3e