Bug 409171 - Crash in Phabricator plugin
Summary: Crash in Phabricator plugin
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-purpose
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR crash
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords: wayland-only
Depends on:
Blocks:
 
Reported: 2019-06-25 10:54 UTC by Nicolas Fella
Modified: 2021-02-28 04:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Backtrace (12.90 KB, text/plain)
2019-06-25 10:54 UTC, Nicolas Fella
Details
local patch (850 bytes, text/plain)
2019-06-25 15:05 UTC, RJVB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Fella 2019-06-25 10:54:37 UTC
Created attachment 121126 [details]
Backtrace

SUMMARY


STEPS TO REPRODUCE
1. Right-click a patch file in Dolphin
2. Share > Phabricator
3. Send

OBSERVED RESULT
Dolphin crashes

KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 5.12.3

ADDITIONAL INFORMATION
Wayland
Comment 1 RJVB 2019-06-25 11:08:21 UTC
Can you please attach a backtrace that shows the exact location of the crash? Also, please describe your procedure more precisely, because there is no "Send" option for uploading to phab. There's a Run button, and first you have to decide whether to create a new diff or attach to an existing one.
Does the crash happen with all files you try to upload?

I cannot reproduce the issue on my end (but I haven't exactly been keeping my install up-to-date since 5.52.0 ...)
Comment 2 Aleix Pol 2019-06-25 13:30:04 UTC
It's already attached.
Comment 3 Nate Graham 2019-06-25 13:52:52 UTC
(In reply to RJVB from comment #1)
> Can you please attach a backtrace that shows the exact location of the
> crash? Also, please describe your procedure more precisely, because there is
> no "Send" option for uploading to phab. There's a Run button
"Run" was changed to "Send" two days ago in https://cgit.kde.org/purpose.git/commit/?id=cad3d131b9b99e0af53194adedb730d66acf6d30

> I cannot reproduce the issue on my end (but I haven't exactly been keeping
> my install up-to-date since 5.52.0 ...)
That's 7 months out of date. I think it makes sense to stay up-to-date on the software you're developing or triaging bugs for.
Comment 4 RJVB 2019-06-25 14:01:37 UTC
The attached backtrace does NOT show the location of a crash. It also doesn't have line numbers, which should be helpful.
Comment 5 RJVB 2019-06-25 15:01:56 UTC
(In reply to Nate Graham from comment #3)

> That's 7 months out of date. I think it makes sense to stay up-to-date on
> the software you're developing or triaging bugs for.

I'm not doing any active development on the Phab plugin, and to be honest I have better things to do in my life nowadays than spending my days keeping all my software up-to-date... (and am not about to start as long as we're having heatwaves :( )

I did manage a partial update of just purpose (and kconfig), which thankfully still build against Qt 5.9.8 . I still don't get the crash when following the posted instructions (and using a random .diff file).
Comment 6 RJVB 2019-06-25 15:05:14 UTC
Created attachment 121139 [details]
local patch

This is the only possibly relevant local modification I make to the source: a tweak that avoids a pure virtual function from getting called. I have have had a crash (abort) for that at some point in the past (since when has gotten lost in the git log).
Comment 7 Christoph Feck 2019-07-16 10:07:38 UTC
That's a quite common crash in wayland code.

Relevant part of the backtrace:

Thread 10 (Thread 0x7fbfd252a700 (LWP 24068)):
#0  0x00007ffff7fb4d77 in wl_proxy_marshal () from /usr/lib/libwayland-client.so.0
#1  0x00007fffefa89d33 in QtWaylandClient::QWaylandAbstractDecoration::contentImage() () from /usr/lib/libQt5WaylandClient.so.5
#2  0x00007fffefb4b909 in ?? () from /usr/lib/qt/plugins/wayland-graphics-integration-client/libqt-plugin-wayland-egl.so
#3  0x00007ffff5fd6f60 in QOpenGLContext::swapBuffers(QSurface*) () from /usr/lib/libQt5Gui.so.5
Comment 8 RJVB 2019-07-16 14:32:46 UTC
(In reply to Christoph Feck from comment #7)
> That's a quite common crash in wayland code.

I hadn't even noticed that the crash was in a wayland library, not even in Qt code. 

Is it safe to say there is no actual bug in the Phab plugin but that it somehow triggers a bug in wayland via a tortuous and unhappy chain of events?

Any hope of figuring out what QML instruction is responsible?

> 
> Relevant part of the backtrace:
> 
> Thread 10 (Thread 0x7fbfd252a700 (LWP 24068)):
> #0  0x00007ffff7fb4d77 in wl_proxy_marshal () from
> /usr/lib/libwayland-client.so.0
> #1  0x00007fffefa89d33 in
> QtWaylandClient::QWaylandAbstractDecoration::contentImage() () from

One possibility that I see is that this has to do with the recent addition of icons (purpose commit #cad3d131b9b99e0af53194adedb730d66acf6d30). That's the only thing the plugin "does with images".
Comment 9 Alex 2021-01-29 12:00:51 UTC
I'm unable to reproduce this on Plasma 5.20.90, does this bug still exist?
Comment 10 Bug Janitor Service 2021-02-13 04:33:10 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Bug Janitor Service 2021-02-28 04:33:17 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!