Created attachment 121117 [details] Screenshot showing the problem SUMMARY I have several albums on my PC which in the ID3 tags only have the same "Album" tag, the Artist tag is different for the songs in these albums. But in Elisa in the "Albums" view I see these albums many times for each artist and each "Album" in Elisa contains only the Album<->Artist combo instead of being grouped into one Album. STEPS TO REPRODUCE 1. Have multiple files with the same Album tag but different Artist tags OBSERVED RESULT Observe that they don't get grouped into one album but into an album per artist EXPECTED RESULT Instead of being one Album per album tag with the different songs/artist being inside that.
Thanks for your report. I have a couple questions needed to better understand what happen. In my case, tracks often have both album and artist album. In this case, the compilation will not get duplicated. Do yours have missing album artist metadata ? There is a feature to not collapse identically named albums in case the path is different (and album artist is missing). This should work under the hypothesis that if the path is different they are probably different albums. Is this your case ?
No, these files don't have an album artist set, from what I can see. They are in the same directory though. I'll attach a screenshot of Kid3 showing two different items in such an album; but aside from being in the same directory, the only metadata-similarity is the Album tag.
Created attachment 121122 [details] Screenshot of kid3 with the metadata of two such files
I have the same issue. In my case the albums also have the 'Compilation' tag set
Confirmed, I have the same problem for my albums where the individual songs have different artists but the Compilation bit is set. The problem seems to happen when the "artist" value differs and there is no "album artist" values set.
I can provide individual files for such albums if necessary, or any other required documentation.
I think this is a result of https://phabricator.kde.org/D20531 Without this, albums of tracks without an album artist tag would not be added to the database. Elisa should probably use more metadata to correctly guess the album artist. The current behavior is also one I've seen with other players I think. Actually, how should Elisa actually know what the correct artist name is?
Created attachment 121412 [details] Image of Clementine showing compilations with an artist of "Various artists"
In reply to comment #7: All other music players I have seen use a generic name for compilation albums. For example the KDE player Clementine calls them "Various artists". See the screen shot I have added.
+1 for showing "Various Artists" as the artist in the grid browser views for albums that have multiple artists. In any of the list views, we should show the different artists for each track when there's space (and when there's not, just omit that column).
(In reply to Nate Graham from comment #10) > +1 for showing "Various Artists" as the artist in the grid browser views for > albums that have multiple artists. In any of the list views, we should show > the different artists for each track when there's space (and when there's > not, just omit that column). It is already the case. It is possible that something got broken and in some case this did not happen.
(In reply to Matthieu Gallien from comment #11) > (In reply to Nate Graham from comment #10) > > +1 for showing "Various Artists" as the artist in the grid browser views for > > albums that have multiple artists. In any of the list views, we should show > > the different artists for each track when there's space (and when there's > > not, just omit that column). > > It is already the case. It is possible that something got broken and in some > case this did not happen. I will try to fix it today if nobody does it before.
(In reply to Matthieu Gallien from comment #12) > (In reply to Matthieu Gallien from comment #11) > > (In reply to Nate Graham from comment #10) > > > +1 for showing "Various Artists" as the artist in the grid browser views for > > > albums that have multiple artists. In any of the list views, we should show > > > the different artists for each track when there's space (and when there's > > > not, just omit that column). > > > > It is already the case. It is possible that something got broken and in some > > case this did not happen. > > I will try to fix it today if nobody does it before. I can reproduce it easily. Let's fix it.
I have a work in progress diff request to fix that: https://phabricator.kde.org/D22499 More work is needed and I do not know when I will be able to do it. There are quite a few corner cases to handle when metadata is missing or partial.
Git commit 61f063362cde8dd26f36cc5ce35740f54702bcdf by Matthieu Gallien. Committed on 06/08/2019 at 20:09. Pushed by mgallien into branch 'master'. fix the compilation album insertion Summary: partial fix for handling albums without album artist partially handle the case of compilations not getting Various Artists as album artist Test Plan: all tests are fine and most common cases should be covered. Reviewers: #elisa, ngraham, astippich Reviewed By: #elisa, ngraham Differential Revision: https://phabricator.kde.org/D22499 M +125 -57 autotests/databaseinterfacetest.cpp M +12 -11 autotests/datamodeltest.cpp M +7 -7 autotests/mediaplaylisttest.cpp M +382 -140 src/databaseinterface.cpp M +4 -3 src/databaseinterface.h M +1 -0 src/mediaplaylist.h M +2 -0 src/models/trackmetadatamodel.cpp https://commits.kde.org/elisa/61f063362cde8dd26f36cc5ce35740f54702bcdf
Thanks, elisa on the latest git commit displays my albums correctly!
*** Bug 413459 has been marked as a duplicate of this bug. ***
*** Bug 413655 has been marked as a duplicate of this bug. ***
*** Bug 415095 has been marked as a duplicate of this bug. ***