Bug 409140 - Buttons for configuration and deleting notifications are in different order in the header and in a notification
Summary: Buttons for configuration and deleting notifications are in different order i...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: master
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-24 15:09 UTC by ariasuni
Modified: 2019-06-25 01:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.2


Attachments
Screenshot augmented with red strokes to highlight the problem (29.69 KB, image/png)
2019-06-24 15:09 UTC, ariasuni
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ariasuni 2019-06-24 15:09:02 UTC
Created attachment 121113 [details]
Screenshot augmented with red strokes to highlight the problem

STEPS TO REPRODUCE
1. Trigger a notification and don’t close it manually
2. Open notifications applet

OBSERVED RESULT
In the header of the notification applet, there is “Clear History” and then “Configuration” button, but the notifications both in or out of this applet have the items in reverse order: “Configuration” then “Close”.

EXPECTED RESULT
In the header of the notification applet, to match the order of the buttons in a notification, there should be a “Configuration” button, then a “Clear History” that doesn’t disappear (to not move buttons depending of applet state) but becomes grey when there is no notification to clear.

SOFTWARE/OS VERSIONS
Arch Linux
KDE Plasma Version: 5.16.1
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.4
Comment 1 Kai Uwe Broulik 2019-06-24 17:40:23 UTC
Git commit 11387ca37f9165429fd37e01e80db75073220971 by Kai Uwe Broulik.
Committed on 24/06/2019 at 17:39.
Pushed by broulik into branch 'Plasma/5.16'.

[Notifications] Swap configure and clear buttons in full representation header

This makes it consistent with the configure button of the items in the list below.
FIXED-IN: 5.16.2

Differential Revision: https://phabricator.kde.org/D22075

M  +7    -7    applets/notifications/package/contents/ui/FullRepresentation.qml

https://commits.kde.org/plasma-workspace/11387ca37f9165429fd37e01e80db75073220971
Comment 2 ariasuni 2019-06-25 01:23:01 UTC
Wow, that was fast! Thanks a lot for the fix :)