Bug 409086 - Pressing Enter on New Numbered Deal dialogue starts game
Summary: Pressing Enter on New Numbered Deal dialogue starts game
Status: RESOLVED FIXED
Alias: None
Product: kpat
Classification: Applications
Component: general (show other bugs)
Version: 3.6
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-23 16:35 UTC by Pedro Lino
Modified: 2020-01-27 10:45 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Lino 2019-06-23 16:35:31 UTC
SUMMARY
Currently pressing Enter after typing the number for a New Numbered Deal does not start the selected game because the focus is on Cancel

STEPS TO REPRODUCE
1. Open the New Numbered Deal (menu or hotkey)
2. Type number (e.g. 5152)
3. Press Enter

OBSERVED RESULT
The dialogue is closed because focus is on the Cancel button

EXPECTED RESULT
The selected game starts

SOFTWARE/OS VERSIONS

KDE Frameworks 5.18.0
Qt 5.5.1 (built against 5.5.1)
The xcb windowing system
Comment 1 Albert Astals Cid 2019-07-30 22:32:11 UTC
> Currently pressing Enter after typing the number for a New Numbered Deal does not start the selected game because the focus is on Cancel

It does for me here. Your versions are quite old, is there any chance you can try a newer version?

Does your distro ship with flatpak?
Comment 2 Pedro Lino 2019-08-07 09:29:30 UTC
(In reply to Albert Astals Cid from comment #1)
> > Currently pressing Enter after typing the number for a New Numbered Deal does not start the selected game because the focus is on Cancel
> 
> It does for me here. Your versions are quite old, is there any chance you
> can try a newer version?

Tried with version 3.6 and

KDE Frameworks 5.44.0
Qt 5.9.5 (built against 5.9.5)
The xcb windowing system

The problem still occurs

> Does your distro ship with flatpak?

Yes, it does.
I'm running Ubuntu 18.04.3 with DE Gnome (maybe that could be the problem?)
Comment 3 Christoph Feck 2019-08-14 01:52:12 UTC
Yes, could be caused by different button order. Could you please try this in Konsole:

    XDG_CURRENT_DESKTOP=kde kpat

This should instruct kpat to use the KDE button order.
Comment 4 Pedro Lino 2019-08-14 10:26:01 UTC
(In reply to Christoph Feck from comment #3)
> Yes, could be caused by different button order. Could you please try this in
> Konsole:
> 
>     XDG_CURRENT_DESKTOP=kde kpat
> 
> This should instruct kpat to use the KDE button order.

That worked. I got "QApplication: invalid style override passed, ignoring it." but typing and pressing Enter does work as expected.

This makes sense because when running kpat under Gnome, the buttons are Cancel and OK, while running your suggested command line, the buttons are OK and Cancel
Comment 5 Bug Janitor Service 2019-08-29 04:33:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Pedro Lino 2019-08-29 07:33:11 UTC
If focus can be attributed to button OK regardless of the button's position on the dialog box then this could be solved otherwise focus will be on the first button which works on KDE but not on Gnome
Comment 7 Christoph Feck 2019-09-17 18:40:18 UTC
I cannot reproduce. The source code explicitely sets the 'OK' button as default, and I confirmed it is the default button executed on Enter with XDG_CURRENT_DESKTOP set to 'kde' or 'gnome'. This even works correctly with the reversed button order for the 'gnome' value.

https://cgit.kde.org/kpat.git/tree/numbereddealdialog.cpp#n33
Comment 8 Pedro Lino 2020-01-27 10:45:35 UTC
Fixed in Version 19.12.1 
This report was for version 3.6 (the only version available at the Ubuntu Software "store" for those who haven't added snap or flatpak)