Bug 409062 - Double animations and lack of fading on Manjaro KDE, latte built from source.
Summary: Double animations and lack of fading on Manjaro KDE, latte built from source.
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: git (master)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-23 04:02 UTC by gregorystarr00
Modified: 2019-06-23 18:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gregorystarr00 2019-06-23 04:02:10 UTC
SUMMARY
Video linked at bottom. At using an applet when a window is fullscreened, the dock goes transparent before fading bake to the correct color. In addition, it correctly fades when a window is maximized, but when minimized, it doesnt have any fading. 

STEPS TO REPRODUCE
1. Use latte-dock as a top panel, latest version, color matching settings
2. Minimize a window or open an applet.
Video here: 

https://drive.google.com/file/d/1V3QO5ELmnmaDWFV_ogC7J9EkmtyCe2aP/view?usp=sharing
Comment 1 Michail Vourlakos 2019-06-23 06:56:36 UTC
send your layout file
Comment 2 Michail Vourlakos 2019-06-23 11:41:47 UTC
sorry I can not find a way to improve this without breaking other things, feel free to contribute if you have a better way to handle it
Comment 3 gregorystarr00 2019-06-23 15:29:40 UTC
(In reply to Michail Vourlakos from comment #2)
> sorry I can not find a way to improve this without breaking other things,
> feel free to contribute if you have a better way to handle it

Why is it infeasible? What is causing the problem?
Comment 4 gregorystarr00 2019-06-23 16:17:34 UTC
(In reply to Michail Vourlakos from comment #2)
> sorry I can not find a way to improve this without breaking other things,
> feel free to contribute if you have a better way to handle it

And why did this not happen on Kubuntu, but does now on Manjaro?
Comment 5 Michail Vourlakos 2019-06-23 16:27:03 UTC
Git commit 1f1188bfc8794786ddcbf1fd910c38059523c5ec by Michail Vourlakos.
Committed on 23/06/2019 at 16:26.
Pushed by mvourlakos into branch 'master'.

improve painting between different backgrounds

M  +7    -3    containment/package/contents/ui/PanelBox.qml

https://commits.kde.org/latte-dock/1f1188bfc8794786ddcbf1fd910c38059523c5ec
Comment 6 Michail Vourlakos 2019-06-23 16:34:12 UTC
Plasma Themes do not support plenty of things for panel backgrounds (different colors, paint themselves etc). In order to overcome this and at the same time Latte to be able to provide the original Plasma experience it uses THREE different backgrounds that cooperate in order to make as smooth to the user as possible. 

The in question code is found at: https://phabricator.kde.org/source/latte-dock/browse/master/containment/package/contents/ui/PanelBox.qml


1. Background 1 is called (backgroundLowestRectangle) and it is responsible to provide full solidness for those plasma themes that DO NOT provide full solidness... There are plenty of plasma themes that the maximum opacity for the panel background is at 80% so the user can not make them fully solid
2. Background 2 is called (solidBackground) it is resposible to provide the plasma experience
3. Background 3 is called (overlayedBackground) it is responsible to provide all the rest Latte enhancements concerning painting... different colors for different windows etc...


Feel free to play with it and provide patches if you are able to improve things without breaking functionality
Comment 7 gregorystarr00 2019-06-23 18:26:47 UTC
(In reply to Michail Vourlakos from comment #6)
> Plasma Themes do not support plenty of things for panel backgrounds
> (different colors, paint themselves etc). In order to overcome this and at
> the same time Latte to be able to provide the original Plasma experience it
> uses THREE different backgrounds that cooperate in order to make as smooth
> to the user as possible. 
> 
> The in question code is found at:
> https://phabricator.kde.org/source/latte-dock/browse/master/containment/
> package/contents/ui/PanelBox.qml
> 
> 
> 1. Background 1 is called (backgroundLowestRectangle) and it is responsible
> to provide full solidness for those plasma themes that DO NOT provide full
> solidness... There are plenty of plasma themes that the maximum opacity for
> the panel background is at 80% so the user can not make them fully solid
> 2. Background 2 is called (solidBackground) it is resposible to provide the
> plasma experience
> 3. Background 3 is called (overlayedBackground) it is responsible to provide
> all the rest Latte enhancements concerning painting... different colors for
> different windows etc...
> 
> 
> Feel free to play with it and provide patches if you are able to improve
> things without breaking functionality


Correct me if I am wrong, (just so I know what I am going to do) Would it be possible to place a condition before animating the background to check if it is already darkened?
Comment 8 Michail Vourlakos 2019-06-23 18:34:21 UTC
I am not sure