Bug 409026 - skrooge appdata.xml fails validation on flathub, needs release and content_rating tags
Summary: skrooge appdata.xml fails validation on flathub, needs release and content_ra...
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: Trunk from git
Platform: Flatpak Linux
: NOR normal
Target Milestone: 25.1.0
Assignee: Guillaume DE BURE
URL:
Keywords:
Depends on:
Blocks: 408970
  Show dependency treegraph
 
Reported: 2019-06-22 09:29 UTC by skierpage
Modified: 2019-06-22 10:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2019-06-22 09:29:47 UTC
SUMMARY
Helpful person TingPing from #flatpak triggered a skrooge build on flathub, but its appdata.xml file fails validation, so the build fails.

STEPS TO REPRODUCE
1. Look at flathub build results in https://flathub.org/builds/#/apps/org.kde.skrooge

OBSERVED RESULT
The flathub build failed, error output https://flathub.org/builds/#/builders/28/builds/566/steps/12/logs/stdio includes
  flatpak run org.freedesktop.appstream-glib validate builddir/*/share/appdata/org.kde.skrooge.appdata.xml
  builddir/files/share/appdata/org.kde.skrooge.appdata.xml: FAILED:
  • tag-missing           : <content_rating> required [use https://odrs.gnome.org/oars]
  • tag-missing           : <release> required
  Validation of files failed

EXPECTED RESULT
Validation succeeds and the flatpak builds.

I compared with https://cgit.kde.org/elisa.git/tree/org.kde.elisa.appdata.xml , read about <releases><release> in https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html , looked at CHANGELOG, and guessed answers to https://odrs.gnome.org/oars , and I think the needed tags for org.kde.skrooge.appdata.xml might be:
  <content_rating type="oars-1.1" />
  <releases>
    <release version="2.19.0" date="2019-04-20"/>
    <release version="2.18.0" date="2019-02-11"/>
    <release version="2.17.0" date="2018-12-16"/>
  </releases>
prepended before its closing </component> tag, though this lacks a <description> for each release. I'll attach the revised file.

SOFTWARE/OS VERSIONS
n/a

ADDITIONAL INFORMATION
`flatpak install org.freedesktop.appstream-glib` installs the infrastructure for the failing command line above.

The reason skrooge needs a rebuild is the KDE platform runtime flatpak was updated to Qt version 5.12.4, and as I understand it, because Skrooge uses Qt plug-ins it must be rebuilt against the same libraries otherwise it fails to run with "Cannot mix incompatible Qt library". See bug 408970 and also flathub issue
Comment 1 skierpage 2019-06-22 09:51:32 UTC
(In reply to skierpage from comment #0)
> I'll attach the revised file.
Bugzilla kept failing with an Apache error, so instead I made my first Differential change, https://phabricator.kde.org/D21984
Comment 2 Stephane MANKOWSKI 2019-06-22 10:54:47 UTC
Git commit b7001e6395d871ceed28b05c6f931ae4665367ef by Stephane MANKOWSKI.
Committed on 22/06/2019 at 10:54.
Pushed by smankowski into branch 'master'.
skrooge appdata.xml fails validation on flathub, needs release and content_rating tags

M  +1    -0    CHANGELOG
M  +6    -0    skrooge/org.kde.skrooge.appdata.xml

https://commits.kde.org/skrooge/b7001e6395d871ceed28b05c6f931ae4665367ef