Bug 409022 - Disk quota icon is semantically incorrect
Summary: Disk quota icon is semantically incorrect
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-22 07:52 UTC by Nicolas Fella
Modified: 2021-11-14 21:34 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Incorrect icon (8.49 KB, image/png)
2019-10-17 08:23 UTC, Serge Pavlyuk
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Fella 2019-06-22 07:52:26 UTC
SUMMARY

The icon shows a disk, but should rather show a disk
Comment 1 Nate Graham 2019-06-22 08:37:15 UTC
Shows a folder but should show a disk, I imagine. :)
Comment 2 Serge Pavlyuk 2019-10-17 08:23:43 UTC
Created attachment 123265 [details]
Incorrect icon

I have, the same problem with other icons (Papirus).
Disk Quoata doesn't look on icons theme.
Comment 3 Björn Feber 2019-10-17 08:27:25 UTC
(In reply to Serge Pavlyuk from comment #2)
> Created attachment 123265 [details]
> Incorrect icon
> 
> I have, the same problem with other icons (Papirus).
> Disk Quoata doesn't look on icons theme.

That's most likely the icon theme's fault.
Comment 4 Serge Pavlyuk 2019-10-17 08:37:12 UTC
(In reply to Björn Feber from comment #3)
> (In reply to Serge Pavlyuk from comment #2)
> > Created attachment 123265 [details]
> > Incorrect icon
> > 
> > I have, the same problem with other icons (Papirus).
> > Disk Quoata doesn't look on icons theme.
> 
> That's most likely the icon theme's fault.

Defently not cause it reproduces on every icon theme
Comment 5 Serge Pavlyuk 2019-10-17 08:38:26 UTC
(In reply to Serge Pavlyuk from comment #4)
> (In reply to Björn Feber from comment #3)
> > (In reply to Serge Pavlyuk from comment #2)
> > > Created attachment 123265 [details]
> > > Incorrect icon
> > > 
> > > I have, the same problem with other icons (Papirus).
> > > Disk Quoata doesn't look on icons theme.
> > 
> > That's most likely the icon theme's fault.
> 
> Defently not cause it reproduces on every icon theme

Unless icon name is renamed and all themes are outdated for this change.
Comment 6 Nicolas Fella 2019-10-17 08:45:00 UTC
The icon in question does not come from the icon theme but from the plasma theme. Changing the icon theme does nothing here
Comment 7 Serge Pavlyuk 2019-10-17 09:03:16 UTC
(In reply to Nicolas Fella from comment #6)
> The icon in question does not come from the icon theme but from the plasma
> theme. Changing the icon theme does nothing here

Thank you. So in this case i need the same patch that would be done for Breeze theme do for any other theme that i know, correct?
Is it possible to track down the bug fix to the patch that will fix it, so i could create a pull request to other themes?
Thank you once again.
Comment 8 Nicolas Fella 2019-10-17 09:09:16 UTC
Well, the "bug" is that the icon should look different. It's a matter of changing https://cgit.kde.org/plasma-framework.git/tree/src/desktoptheme/breeze/icons/disk.svg
Comment 9 Bug Janitor Service 2021-11-14 21:32:08 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/170
Comment 10 andreas 2021-11-14 21:34:31 UTC
Git commit 8936f14e15cff18171e73b8ffa69cce1b339db76 by Andreas Kainz.
Committed on 14/11/2021 at 21:31.
Pushed by andreask into branch 'master'.

M  +20   -13   icons-dark/status/22/disk-quota-critical.svg
M  +17   -9    icons-dark/status/22/disk-quota-high.svg
M  +12   -6    icons-dark/status/22/disk-quota-low.svg
M  +14   -8    icons-dark/status/22/disk-quota.svg
M  +20   -13   icons/status/22/disk-quota-critical.svg
M  +17   -9    icons/status/22/disk-quota-high.svg
M  +12   -6    icons/status/22/disk-quota-low.svg
M  +14   -8    icons/status/22/disk-quota.svg

https://invent.kde.org/frameworks/breeze-icons/commit/8936f14e15cff18171e73b8ffa69cce1b339db76