Bug 409013 - Fix background color and frame of search result
Summary: Fix background color and frame of search result
Status: RESOLVED NOT A BUG
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.6.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-21 21:19 UTC by Thomas Bingel
Modified: 2019-06-24 18:21 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Useless search function (250.74 KB, image/png)
2019-06-24 05:35 UTC, Thomas Bingel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Bingel 2019-06-21 21:19:25 UTC
It is absolutely annoying that the background color of search results is the same as the standard color for highlighting text, i.e. yellow
2) It very annoying that the frame around the search result is a very thin black box. This should be way more prominent also to compensate for above annoyance!

I have previously suggested to use a color for search results that is not available for other functionality like highlighting!

If you highlight a lot in a PDF file then the search function becomes essentially useless! Very annoying!

Would you finally please fix this annoyance!!!



SUMMARY


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Albert Astals Cid 2019-06-22 10:47:50 UTC
"I have previously suggested to use a color for search results that is not available for other functionality like highlighting!"

What makes you think reporting it again and being aggressive will give you a different result?
Comment 2 Thomas Bingel 2019-06-22 17:50:24 UTC
Of course this is a serious usability bug!
If in the most common use case scenario the search function becomes essentially useless this is a severe but that should have been fixed years ago!

I will report this bug as often as it is necessary to get this into a programmer's head!

Please finally fix it! It would be greatly appreciated!

Plus: That the count of search results is not shown is another flaw with the search function in Okular!
Comment 3 Albert Astals Cid 2019-06-22 18:23:54 UTC
I can get your account banned if that's what you want
Comment 4 Thomas Bingel 2019-06-22 18:29:31 UTC
So Albert you are also an authoritarian dictator! Perhaps your account should be reviewed!
Comment 5 Thomas Bingel 2019-06-22 18:34:13 UTC
Albert I think you should seek some advice from your colleagues at KDE
Comment 6 Oliver Sander 2019-06-22 18:42:31 UTC
Dear Thomas, please consider that Okular is developed almost exclusively by volunteers, who decide for themselves the topics they want to work on.  At the same time, Okular is rather understaffed; lot's of important topics are not being worked on for lack of manpower.

If that highlighting issue means so much to you, and you are not able to fix it yourself, you can buy professional Okular bugfixing from several companies.  Consider doing that: I have tried it myself and it works nicely.
Comment 7 Thomas Bingel 2019-06-22 21:59:01 UTC
Hello Oliver,

oder auch Professur für Numerik partieller Differentialgleichungen
Prof. Dr. Oliver Sander wie ich annehme. Danke, dass sie sich der Sache angenommen haben.

I am fully aware that volunteers work on this software. I also work as a volunteer and heavy user of Okular software to address shortcomings and report them here in hope and in confidence that one day they will be fixed or improved upon.

Thanks for explaining that there are few resources available for Okular!
How large is actually the user community?
What did you mean by commercial bug fixes available for Okular? Can you please provide an example?

However, Albert Astals Cid comes across as pretty immature and narrow minded! Perhaps, he should be taken off this Okular project!
As a minimum, I would expect him to appreciate my efforts to help improve the product. More appropriately and professionally, he should take my valid suggestions under advisement and introduce them in the change requests.
Comment 8 Thomas Bingel 2019-06-23 16:41:41 UTC
Albert can you classify my suggestion for improvement in a smarter way instead of "Resolved not a bug".
YES, it is a severe usability bug rendering the search function useless in a very common use case scenario!
Please choose a better disposition! Thanks!
Comment 9 Yuri Chornoivan 2019-06-23 16:53:23 UTC
For me, it is not a severe bug as well.

@Thomas: Nobody owes you anything. Please stop trolling developers.
Comment 10 Thomas Bingel 2019-06-23 20:13:02 UTC
Hello Yuri,

you seem to have a similar arrogant attitude like Albert Astals Cid!
It is a severe usability bug in Okular rendering the search function useless. Why don't you use your brain a little bit more instead of calling other volunteers here to be trolling!
By the way, I am also a software developer and a heavy user of Okular!
Comment 11 Oliver Sander 2019-06-23 20:19:38 UTC
> you seem to have a similar arrogant attitude like Albert Astals Cid!

In all politeness, this is not the place for personality judgements -- it is a bug report about highlighting colors.

> It is a severe usability bug in Okular rendering the search function useless.

Please accept that it may be severe for you, but it isn't for others.  I for one search every day, and the yellow color doesn't bother me at all.

> Why don't you use your brain a little bit more instead of calling other volunteers here to be trolling!

(see above)

> By the way, I am also a software developer and a heavy user of Okular!

Then by all means you should be able to fix this yourself.  The relevant code is  in the file pagepainter.cpp, lines 400ff.
Comment 12 Thomas Bingel 2019-06-24 05:33:17 UTC
Professor Sanders from the TU Dresden you are very disappointing! You did not even answer my questions in my last comment to you! Your last outright commentary is quite foolish!

Given your last commentary, I truly doubt that you even comprehended what the issue is about.
Let me try to explain the issue with an example so that even a professor can understand it:
Let's assume we have a 12 page typical research paper as PDF. You have extensively highlighted in yellow about 20 passages (partial paragraphs, whole sentences, part of sentences etc.) throughout the document. Then you want to search for a frequently occurring term in that paper. Several of the highlighted passage also contain the search term, occasionally more than once per highlighted passage. Try that professor!

You are so smart aleck that it is almost shocking! Can you imagine that I used to program in C# (not C++) and in Oracle SQL. Currently, I am learning Python and machine learning frameworks like TensorFlow and PyTorch. 

If you already know which source file and lines of code that need to be modified to fix this issue why don't you tell Albert Astals Cid? Or do it yourself. We could long done with it!

Meanwhile, I have attached here a screen shot showing that this issue is even more severe than I had previously described here. Tell me if you can easily identify on the screen shot where the search function found the search term, i.e. cls, on the picture?

Professor Sanders you are pathetic let me tell you!
Comment 13 Thomas Bingel 2019-06-24 05:35:03 UTC
Created attachment 121106 [details]
Useless search function

It is very difficult to spot where on the image the search function found the search term
Comment 14 Ben Cooksley 2019-06-24 18:21:09 UTC
Reclosing Bug.